From: Sumit Garg <sumit.garg@linaro.org>
To: will@kernel.org, catalin.marinas@arm.com
Cc: mark.rutland@arm.com, daniel.thompson@linaro.org,
dianders@chromium.org, liwei391@huawei.com, mhiramat@kernel.org,
maz@kernel.org, ardb@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Sumit Garg <sumit.garg@linaro.org>
Subject: [PATCH v6 0/2] arm64: Fix pending single-step debugging issues
Date: Thu, 2 Feb 2023 13:01:46 +0530 [thread overview]
Message-ID: <20230202073148.657746-1-sumit.garg@linaro.org> (raw)
This patch-set reworks pending fixes from Wei's series [1] to make
single-step debugging via kgdb/kdb on arm64 work as expected. There was
a prior discussion on ML [2] regarding if we should keep the interrupts
enabled during single-stepping. So patch #1 follows suggestion from Will
[3] to not disable interrupts during single stepping but rather skip
single stepping within interrupt handler.
[1] https://lore.kernel.org/all/20200509214159.19680-1-liwei391@huawei.com/
[2] https://lore.kernel.org/all/CAD=FV=Voyfq3Qz0T3RY+aYWYJ0utdH=P_AweB=13rcV8GDBeyQ@mail.gmail.com/
[3] https://lore.kernel.org/all/20200626095551.GA9312@willie-the-truck/
Changes in v6:
- Fix incorrect rescheduling check introduced by rework for v5.
- Patch #2: s/kernel_regs_reset_single_step/kernel_rewind_single_step/
- Collected Daniel's tags.
Changes in v5:
- Incorporated misc. comments from Mark.
Changes in v4:
- Rebased to the tip of mainline.
- Picked up Doug's Tested-by tag.
Changes in v3:
- Reword commit descriptions as per Daniel's suggestions.
Changes in v2:
- Replace patch #1 to rather follow Will's suggestion.
Sumit Garg (2):
arm64: entry: Skip single stepping into interrupt handlers
arm64: kgdb: Set PSTATE.SS to 1 to re-enable single-step
arch/arm64/include/asm/debug-monitors.h | 1 +
arch/arm64/kernel/debug-monitors.c | 5 +++++
arch/arm64/kernel/entry-common.c | 22 ++++++++++++++++++++--
arch/arm64/kernel/kgdb.c | 2 ++
4 files changed, 28 insertions(+), 2 deletions(-)
--
2.34.1
next reply other threads:[~2023-02-02 7:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 7:31 Sumit Garg [this message]
2023-02-02 7:31 ` [PATCH v6 1/2] arm64: entry: Skip single stepping into interrupt handlers Sumit Garg
2025-09-24 11:59 ` Matthias Schiffer
2023-02-02 7:31 ` [PATCH v6 2/2] arm64: kgdb: Set PSTATE.SS to 1 to re-enable single-step Sumit Garg
2023-02-22 7:06 ` [PATCH v6 0/2] arm64: Fix pending single-step debugging issues Sumit Garg
2023-04-14 14:38 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230202073148.657746-1-sumit.garg@linaro.org \
--to=sumit.garg@linaro.org \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mhiramat@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®