mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vipin Sharma <vipinsh@google.com>
To: seanjc@google.com, pbonzini@redhat.com, maz@kernel.org,
	james.morse@arm.com, suzuki.poulose@arm.com,
	oliver.upton@linux.dev, yuzenghui@huawei.com,
	borntraeger@linux.ibm.com, frankja@linux.ibm.com,
	imbrenda@linux.ibm.com, david@redhat.com
Cc: dmatlack@google.com, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, Vipin Sharma <vipinsh@google.com>
Subject: [Patch v2 2/4] KVM: selftests: Print expected and actual exit reason in KVM exit reason assert
Date: Fri,  3 Feb 2023 17:45:45 -0800	[thread overview]
Message-ID: <20230204014547.583711-3-vipinsh@google.com> (raw)
In-Reply-To: <20230204014547.583711-1-vipinsh@google.com>

Print what KVM exit reason a test was expecting and what it actually
got int TEST_ASSERT_KVM_EXIT_REASON().

Signed-off-by: Vipin Sharma <vipinsh@google.com>
---
 tools/testing/selftests/kvm/include/test_util.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/kvm/include/test_util.h b/tools/testing/selftests/kvm/include/test_util.h
index a13663557e2b..a6e9f215ce70 100644
--- a/tools/testing/selftests/kvm/include/test_util.h
+++ b/tools/testing/selftests/kvm/include/test_util.h
@@ -67,7 +67,8 @@ void test_assert(bool exp, const char *exp_str,
 	__u32 exit_reason = (vcpu)->run->exit_reason;			\
 									\
 	TEST_ASSERT(exit_reason == (expected),				\
-		    "Unexpected exit reason: %u (%s)",			\
+		    "Wanted KVM exit reason: %u (%s), got: %u (%s)",    \
+		    (expected), exit_reason_str((expected)),		\
 		    exit_reason, exit_reason_str(exit_reason));		\
 } while (0)
 
-- 
2.39.1.519.gcb327c4b5f-goog


  parent reply	other threads:[~2023-02-04  1:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-04  1:45 [Patch v2 0/4] Common KVM exit reason test assertions and exit reason sync Vipin Sharma
2023-02-04  1:45 ` [Patch v2 1/4] KVM: selftests: Make vCPU exit reason test assertion common Vipin Sharma
2023-02-04  1:45 ` Vipin Sharma [this message]
2023-02-04  1:45 ` [Patch v2 3/4] KVM: selftests: Add macro to generate KVM exit reason strings Vipin Sharma
2023-02-06 20:51   ` Vipin Sharma
2023-02-04  1:45 ` [Patch v2 4/4] KVM: selftests: Sync KVM exit reasons in selftests Vipin Sharma
2023-03-06 18:41 ` [Patch v2 0/4] Common KVM exit reason test assertions and exit reason sync Vipin Sharma
2023-03-14 13:55 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230204014547.583711-3-vipinsh@google.com \
    --to=vipinsh@google.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=david@redhat.com \
    --cc=dmatlack@google.com \
    --cc=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=james.morse@arm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=suzuki.poulose@arm.com \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®