From: "Joel Fernandes (Google)" <joel@joelfernandes.org>
To: linux-kernel@vger.kernel.org
Cc: "Joel Fernandes (Google)" <joel@joelfernandes.org>,
Qiang Zhang <Qiang1.zhang@intel.com>,
Frederic Weisbecker <frederic@kernel.org>,
Josh Triplett <josh@joshtriplett.org>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
rcu@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>,
Boqun Feng <boqun.feng@gmail.com>
Subject: [PATCH] rcu/tree: Improve comments in rcu_report_qs_rdp()
Date: Sat, 4 Feb 2023 02:20:50 +0000 [thread overview]
Message-ID: <20230204022051.2737724-1-joel@joelfernandes.org> (raw)
Recent discussion triggered due to a patch linked below, from Qiang,
shed light on the need to accelerate from QS reporting paths.
Update the comments to capture this piece of knowledge.
Link: https://lore.kernel.org/all/20230118073014.2020743-1-qiang1.zhang@intel.com/
Cc: Qiang Zhang <Qiang1.zhang@intel.com>
Cc: Frederic Weisbecker <frederic@kernel.org>
Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
---
kernel/rcu/tree.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 93eb03f8ed99..713eb6ca6902 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -1983,7 +1983,12 @@ rcu_report_qs_rdp(struct rcu_data *rdp)
} else {
/*
* This GP can't end until cpu checks in, so all of our
- * callbacks can be processed during the next GP.
+ * callbacks can be processed during the next GP. Do
+ * the acceleration from here otherwise there may be extra
+ * grace period delays, as any accelerations from rcu_core()
+ * or note_gp_changes() may happen only after the GP after the
+ * current one has already started. Further, rcu_core()
+ * only accelerates if RCU is idle (no GP in progress).
*
* NOCB kthreads have their own way to deal with that...
*/
@@ -1993,6 +1998,12 @@ rcu_report_qs_rdp(struct rcu_data *rdp)
/*
* ...but NOCB kthreads may miss or delay callbacks acceleration
* if in the middle of a (de-)offloading process.
+ *
+ * Such missed acceleration may cause the callbacks to
+ * be stranded until RCU is fully de-offloaded, as
+ * acceleration from rcu_core() and note_gp_changes()
+ * cannot happen for fully/partially offloaded mode due
+ * to ordering dependency between rnp lock and nocb_lock.
*/
needacc = true;
}
--
2.39.1.519.gcb327c4b5f-goog
next reply other threads:[~2023-02-04 2:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-04 2:20 Joel Fernandes (Google) [this message]
2023-02-06 3:09 ` Zhang, Qiang1
2023-02-06 17:19 ` Joel Fernandes
2023-02-06 17:24 ` Joel Fernandes
2023-02-07 1:14 ` Zhang, Qiang1
2023-02-10 23:55 ` Joel Fernandes
2023-02-07 13:24 ` Frederic Weisbecker
2023-02-10 23:46 ` Joel Fernandes
2023-02-11 11:18 ` Zhang, Qiang1
2023-02-13 14:43 ` Joel Fernandes
2023-02-14 8:17 ` Zhang, Qiang1
2023-02-11 0:32 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230204022051.2737724-1-joel@joelfernandes.org \
--to=joel@joelfernandes.org \
--cc=Qiang1.zhang@intel.com \
--cc=boqun.feng@gmail.com \
--cc=frederic@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®