From: Martin Kaiser <martin@kaiser.cx>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Michael Straube <straube.linux@gmail.com>,
Pavel Skripkin <paskripkin@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Martin Kaiser <martin@kaiser.cx>
Subject: [PATCH 1/7] staging: r8188eu: merge do_queue_select into its only caller
Date: Tue, 7 Feb 2023 20:23:13 +0100 [thread overview]
Message-ID: <20230207192319.294203-2-martin@kaiser.cx> (raw)
In-Reply-To: <20230207192319.294203-1-martin@kaiser.cx>
Merge do_queue_select into its only caller. It's only a simple assignment.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/r8188eu/core/rtw_xmit.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_xmit.c b/drivers/staging/r8188eu/core/rtw_xmit.c
index 18941320e70e..4d6210d89533 100644
--- a/drivers/staging/r8188eu/core/rtw_xmit.c
+++ b/drivers/staging/r8188eu/core/rtw_xmit.c
@@ -1609,15 +1609,6 @@ u32 rtw_get_ff_hwaddr(struct xmit_frame *pxmitframe)
return addr;
}
-static void do_queue_select(struct adapter *padapter, struct pkt_attrib *pattrib)
-{
- u8 qsel;
-
- qsel = pattrib->priority;
-
- pattrib->qsel = qsel;
-}
-
/*
* The main transmit(tx) entry
*
@@ -1656,7 +1647,7 @@ s32 rtw_xmit(struct adapter *padapter, struct sk_buff **ppkt)
rtw_led_control(padapter, LED_CTL_TX);
- do_queue_select(padapter, &pxmitframe->attrib);
+ pxmitframe->attrib.qsel = pxmitframe->attrib.priority;
spin_lock_bh(&pxmitpriv->lock);
if (xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe)) {
--
2.30.2
next prev parent reply other threads:[~2023-02-07 19:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 19:23 [PATCH 0/7] staging: r8188eu: another round of xmit cleanups Martin Kaiser
2023-02-07 19:23 ` Martin Kaiser [this message]
2023-02-07 19:23 ` [PATCH 2/7] staging: r8188eu: simplify rtw_alloc_xmitframe Martin Kaiser
2023-02-07 19:23 ` [PATCH 3/7] staging: r8188eu: remove unused frametag defines Martin Kaiser
2023-02-07 19:23 ` [PATCH 4/7] staging: r8188eu: xmit_buf's ff_hwaddr is not used Martin Kaiser
2023-02-07 19:23 ` [PATCH 5/7] staging: r8188eu: simplify xmit_buf flags Martin Kaiser
2023-02-07 19:23 ` [PATCH 6/7] staging: r8188eu: simplify rtw_get_ff_hwaddr Martin Kaiser
2023-02-07 19:23 ` [PATCH 7/7] staging: r8188eu: bagg_pkt parameter is not used Martin Kaiser
2023-02-07 19:46 ` [PATCH 0/7] staging: r8188eu: another round of xmit cleanups Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230207192319.294203-2-martin@kaiser.cx \
--to=martin@kaiser.cx \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®