From: "Paul E. McKenney" <paulmck@kernel.org>
To: Willy Tarreau <w@1wt.eu>
Cc: chris.chenfeiyang@gmail.com,
Feiyang Chen <chenfeiyang@loongson.cn>,
chenhuacai@kernel.org, jiaxun.yang@flygoat.com, arnd@arndb.de,
loongarch@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] selftests/nolibc: Add support for LoongArch
Date: Tue, 7 Feb 2023 20:34:40 -0800 [thread overview]
Message-ID: <20230208043440.GA3164268@paulmck-ThinkPad-P17-Gen-1> (raw)
In-Reply-To: <Y+Mc37ACt0PUBRAQ@1wt.eu>
On Wed, Feb 08, 2023 at 04:54:07AM +0100, Willy Tarreau wrote:
> On Tue, Feb 07, 2023 at 10:09:42AM +0800, chris.chenfeiyang@gmail.com wrote:
> > From: Feiyang Chen <chenfeiyang@loongson.cn>
> >
> > Add support for LoongArch (64 bit) to nolibc selftest.
>
> Please also mention in this one that the makefile was reindented with
> no other change than adding entries for loongarch, this will save
> those reading this patch later from checking that the rest was not
> changed.
I like Willy's suggestion, but even better would be to put the whitespace
changes into one commit, and the code changes into another commit.
This makes it a lot easier for reviewers and future nolibc developers
to quickly and easily see exactly what changed.
And one of those future nolibc maintainers just might be you! ;-)
Thanx, Paul
next prev parent reply other threads:[~2023-02-08 4:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 2:09 [PATCH 0/3] Add LoongArch support to nolibc chris.chenfeiyang
2023-02-07 2:09 ` [PATCH 1/3] nolibc: Add statx() support to implement sys_stat() chris.chenfeiyang
2023-02-07 14:30 ` Arnd Bergmann
2023-02-08 2:09 ` Feiyang Chen
2023-02-08 3:31 ` Willy Tarreau
2023-02-08 7:29 ` Arnd Bergmann
2023-02-08 7:42 ` Feiyang Chen
2023-02-08 8:06 ` Arnd Bergmann
2023-02-08 8:19 ` Willy Tarreau
2023-02-08 9:20 ` Feiyang Chen
[not found] ` <d0df35466db74097b8e70e28d35a4776@AcuMS.aculab.com>
2023-02-08 14:07 ` Willy Tarreau
2023-02-08 8:07 ` Willy Tarreau
2023-02-07 2:09 ` [PATCH 2/3] nolibc: Add support for LoongArch chris.chenfeiyang
2023-02-07 14:25 ` Arnd Bergmann
2023-02-07 2:09 ` [PATCH 3/3] selftests/nolibc: " chris.chenfeiyang
2023-02-08 3:54 ` Willy Tarreau
2023-02-08 4:34 ` Paul E. McKenney [this message]
2023-02-08 6:39 ` Feiyang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230208043440.GA3164268@paulmck-ThinkPad-P17-Gen-1 \
--to=paulmck@kernel.org \
--cc=arnd@arndb.de \
--cc=chenfeiyang@loongson.cn \
--cc=chenhuacai@kernel.org \
--cc=chris.chenfeiyang@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®