mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Palmer Dabbelt <palmer@rivosinc.com>
To: linux-riscv@lists.infradead.org
Cc: daniel.lezcano@linaro.org, tglx@linutronix.de,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	aou@eecs.berkeley.edu, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org, linux@rivosinc.com,
	Palmer Dabbelt <palmer@rivosinc.com>
Subject: [PATCH] clocksource/drivers/riscv: Refuse to probe on T-Head
Date: Thu,  9 Feb 2023 15:23:02 -0800	[thread overview]
Message-ID: <20230209232302.25658-1-palmer@rivosinc.com> (raw)

From: Palmer Dabbelt <palmer@rivosinc.com>

As of d9f15a9de44a ("Revert "clocksource/drivers/riscv: Events are
stopped during CPU suspend"") this driver no longer functions correctly
for the T-Head firmware.  That shouldn't impact any users, as we've got
a functioning driver that's higher priority, but let's just be safe and
ban it from probing at all.

Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
---
This feel super ugly to me, but I'm not sure how to do this more
cleanly.  I'm not even sure if it's necessary, but I just ran back into
the driver reviewing some other patches so I figured I'd say something.
---
 drivers/clocksource/timer-riscv.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/drivers/clocksource/timer-riscv.c b/drivers/clocksource/timer-riscv.c
index a0d66fabf073..d2d0236d1ae6 100644
--- a/drivers/clocksource/timer-riscv.c
+++ b/drivers/clocksource/timer-riscv.c
@@ -139,6 +139,22 @@ static int __init riscv_timer_init_dt(struct device_node *n)
 	if (cpuid != smp_processor_id())
 		return 0;
 
+	/*
+	 * The T-Head firmware does not route timer interrups to the core
+	 * during non-retentive suspend.  This is allowed by the specifications
+	 * (no interrupts are required to wake up the core during non-retentive
+	 * suspend), but most systems don't behave that way and Linux just
+	 * assumes that interrupts work.
+	 *
+	 * There's another timer for the T-Head sytems that behave this way
+	 * that is already probed by default, but just to be sure skip
+	 * initializing the SBI driver as it'll just break things later.
+	 */
+	if (sbi_get_mvendorid() == THEAD_VENDOR_ID) {
+		pr_debug_once("Skipping SBI timer on T-Head due to missed wakeups");
+		return 0;
+	}
+
 	domain = NULL;
 	child = of_get_compatible_child(n, "riscv,cpu-intc");
 	if (!child) {
-- 
2.39.1


             reply	other threads:[~2023-02-09 23:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-09 23:23 Palmer Dabbelt [this message]
2023-02-09 23:35 ` Samuel Holland
2023-02-09 23:39   ` Palmer Dabbelt
2023-02-09 23:40 ` Conor Dooley
2023-02-09 23:48   ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230209232302.25658-1-palmer@rivosinc.com \
    --to=palmer@rivosinc.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux@rivosinc.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®