mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Longlong Xia <xialonglong1@huawei.com>
To: <gregkh@linuxfoundation.org>
Cc: <chenwandun@huawei.com>, <linux-kernel@vger.kernel.org>,
	<rafael@kernel.org>, <sunnanyong@huawei.com>,
	<wangkefeng.wang@huawei.com>, <xialonglong1@huawei.com>
Subject: [PATCH -next 1/3] devtmpfs: add debug info to handle()
Date: Fri, 10 Feb 2023 07:33:07 +0000	[thread overview]
Message-ID: <20230210073309.4050841-2-xialonglong1@huawei.com> (raw)
In-Reply-To: <20230210073309.4050841-1-xialonglong1@huawei.com>

Because handle() is the core function for processing devtmpfs requests,
Let's add some debug info in handle() to help users know why failed.

Signed-off-by: Longlong Xia <xialonglong1@huawei.com>
---
 drivers/base/devtmpfs.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/drivers/base/devtmpfs.c b/drivers/base/devtmpfs.c
index ae72d4ba8547..7789b7be4ee5 100644
--- a/drivers/base/devtmpfs.c
+++ b/drivers/base/devtmpfs.c
@@ -389,10 +389,18 @@ static __initdata DECLARE_COMPLETION(setup_done);
 static int handle(const char *name, umode_t mode, kuid_t uid, kgid_t gid,
 		  struct device *dev)
 {
+	int ret;
+
 	if (mode)
-		return handle_create(name, mode, uid, gid, dev);
+		ret = handle_create(name, mode, uid, gid, dev);
 	else
-		return handle_remove(name, dev);
+		ret = handle_remove(name, dev);
+
+	if (ret)
+		dev_err(dev, "failed to %s %s, ret = %d\n",
+			mode ? "create" : "remove", name, ret);
+
+	return ret;
 }
 
 static void __noreturn devtmpfs_work_loop(void)
-- 
2.25.1


  reply	other threads:[~2023-02-10  7:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-02  3:32 [PATCH -next 0/3] cleanup of devtmpfs_*_node() Longlong Xia
2023-02-02  3:32 ` [PATCH -next 1/3] devtmpfs: convert to pr_fmt Longlong Xia
2023-02-02  8:33   ` Greg KH
2023-02-02  3:32 ` [PATCH -next 2/3] devtmpfs: add debug info to handle() Longlong Xia
2023-02-02  8:30   ` Greg KH
2023-02-10  7:33     ` [PATCH -next 0/3] cleanup of devtmpfs_*_node() Longlong Xia
2023-02-10  7:33       ` Longlong Xia [this message]
2023-02-10  7:33       ` [PATCH -next 2/3] driver core: add error handling for devtmpfs_create_node() Longlong Xia
2023-02-10  7:33       ` [PATCH -next 3/3] devtmpfs: remove return value of devtmpfs_delete_node() Longlong Xia
2023-02-10  8:17       ` [PATCH -next 0/3] cleanup of devtmpfs_*_node() Greg KH
2023-02-02  3:32 ` [PATCH -next 3/3] devtmpfs: remove return value of devtmpfs_*_node() & devtmpfs_submit_req() Longlong Xia
2023-02-02  8:33   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230210073309.4050841-2-xialonglong1@huawei.com \
    --to=xialonglong1@huawei.com \
    --cc=chenwandun@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=sunnanyong@huawei.com \
    --cc=wangkefeng.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®