From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95625C636CD for ; Fri, 10 Feb 2023 10:52:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231891AbjBJKwm (ORCPT ); Fri, 10 Feb 2023 05:52:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231569AbjBJKwi (ORCPT ); Fri, 10 Feb 2023 05:52:38 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39786212A1 for ; Fri, 10 Feb 2023 02:52:37 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pQR14-0006vJ-EM; Fri, 10 Feb 2023 11:52:30 +0100 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1pQR12-0007mg-Fc; Fri, 10 Feb 2023 11:52:28 +0100 Date: Fri, 10 Feb 2023 11:52:28 +0100 From: Sascha Hauer To: linux-wireless@vger.kernel.org Cc: Neo Jou , Hans Ulli Kroll , Ping-Ke Shih , Yan-Hsuan Chuang , Kalle Valo , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Blumenstingl , kernel@pengutronix.de, Alexander Hochbaum , Da Xue , Po-Hao Huang , Andreas Henriksson , Viktor Petrenko Subject: Re: [PATCH 2/2] wifi: rtw88: usb: Fix urbs with size multiple of bulkout_size Message-ID: <20230210105228.GK23347@pengutronix.de> References: <20230210092642.685905-1-s.hauer@pengutronix.de> <20230210092642.685905-3-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230210092642.685905-3-s.hauer@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 10, 2023 at 10:26:42AM +0100, Sascha Hauer wrote: > The hardware can't handle urbs with a data size of multiple of > bulkout_size. With such a packet the endpoint gets stuck and only > replugging the hardware helps. > > Fix this by moving the header eight bytes down, thus making the packet > eight bytes bigger. The same is done in rtw_usb_write_data_rsvd_page() > already, but not yet for the tx data. > > Fixes: a82dfd33d1237 ("wifi: rtw88: Add common USB chip support") > Signed-off-by: Sascha Hauer > --- > drivers/net/wireless/realtek/rtw88/tx.h | 2 ++ > drivers/net/wireless/realtek/rtw88/usb.c | 34 +++++++++++++++--------- > 2 files changed, 24 insertions(+), 12 deletions(-) Please ignore this patch. The problem is real and this patch fixes it, but it's way cleaner and more straight forward to just go the USB way and set the URB_ZERO_PACKET flag. I'll send an updated series shortly. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |