From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Alexander Sverdlin <alexander.sverdlin@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: [PATCH] driver: core: Prevent NULL pointer dereference in device name functions
Date: Sun, 12 Feb 2023 23:04:41 +0100 [thread overview]
Message-ID: <20230212220441.258258-1-alexander.sverdlin@gmail.com> (raw)
Prevent similar scenarios:
Unable to handle kernel NULL pointer dereference at virtual address 00000038
...
PC is at dev_driver_string+0x0/0x38
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
---
drivers/base/core.c | 3 +++
include/linux/device.h | 5 +++++
2 files changed, 8 insertions(+)
diff --git a/drivers/base/core.c b/drivers/base/core.c
index a3e14143ec0c..4ff2ddea7c9b 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -2174,6 +2174,9 @@ const char *dev_driver_string(const struct device *dev)
{
struct device_driver *drv;
+ if (!dev)
+ return "<null>";
+
/* dev->driver can change to NULL underneath us because of unbinding,
* so be careful about accessing it. dev->bus and dev->class should
* never change once they are set, so they don't need special care.
diff --git a/include/linux/device.h b/include/linux/device.h
index 44e3acae7b36..ff9e19e6d78c 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -696,6 +696,9 @@ static inline bool device_iommu_mapped(struct device *dev)
static inline const char *dev_name(const struct device *dev)
{
+ if (!dev)
+ return "<null>";
+
/* Use the init name until the kobject becomes available */
if (dev->init_name)
return dev->init_name;
@@ -712,6 +715,8 @@ static inline const char *dev_name(const struct device *dev)
*/
static inline const char *dev_bus_name(const struct device *dev)
{
+ if (!dev)
+ return "<null>";
return dev->bus ? dev->bus->name : (dev->class ? dev->class->name : "");
}
--
2.39.1
next reply other threads:[~2023-02-12 22:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-12 22:04 Alexander Sverdlin [this message]
2023-02-13 7:07 ` Greg Kroah-Hartman
2023-02-13 7:12 ` Alexander Sverdlin
2023-02-13 7:16 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230212220441.258258-1-alexander.sverdlin@gmail.com \
--to=alexander.sverdlin@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®