From: Mike Christie <michael.christie@oracle.com>
To: brauner@kernel.org, ebiederm@xmission.com,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Cc: Mike Christie <michael.christie@oracle.com>
Subject: [PATCH 2/5] kernel: Add kernel_clone_fns function to setup task
Date: Sun, 12 Feb 2023 19:00:17 -0600 [thread overview]
Message-ID: <20230213010020.1813-3-michael.christie@oracle.com> (raw)
In-Reply-To: <20230213010020.1813-1-michael.christie@oracle.com>
The io_uring code will set it's worker threads's name with a
iou-sqd/iou-wrk prefix and then either the task's pid or the task's
parent's pid. The kthread code will set the name to whatever the caller
decides. To set these names they have come up with different approaches.
This patch adds a callout to setup a kthread or io_uring worker's
internal struct and/or set the task's coomm.
Signed-off-by: Mike Christie <michael.christie@oracle.com>
---
include/linux/sched.h | 2 ++
include/linux/sched/task.h | 1 +
kernel/fork.c | 6 ++++++
3 files changed, 9 insertions(+)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 853d08f7562b..09bdc71c0523 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1066,6 +1066,8 @@ struct task_struct {
* executable name, excluding path.
*
* - normally initialized setup_new_exec()
+ * - can be initialized in copy_process if
+ * kernel_clone_args.fns.setup_thread_fn() is set.
* - access it with [gs]et_task_comm()
* - lock it with task_lock()
*/
diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h
index 7a61ebbcdfe0..844824e0023c 100644
--- a/include/linux/sched/task.h
+++ b/include/linux/sched/task.h
@@ -20,6 +20,7 @@ struct css_set;
struct kernel_clone_fns {
int (*thread_fn)(void *fn_arg);
+ int (*setup_thread_fn)(struct task_struct *tsk, void *fn_arg);
};
struct kernel_clone_args {
diff --git a/kernel/fork.c b/kernel/fork.c
index f308a5ae0ed3..057274da64fb 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -2345,6 +2345,12 @@ static __latent_entropy struct task_struct *copy_process(
p->tgid = p->pid;
}
+ if (args->fns && args->fns->setup_thread_fn) {
+ retval = args->fns->setup_thread_fn(p, args->fn_arg);
+ if (retval)
+ goto bad_fork_put_pidfd;
+ }
+
p->nr_dirtied = 0;
p->nr_dirtied_pause = 128 >> (PAGE_SHIFT - 10);
p->dirty_paused_when = 0;
--
2.25.1
next prev parent reply other threads:[~2023-02-13 1:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 1:00 [PATCH 0/5] kernel: Standardize task comm setup for kthreads Mike Christie
2023-02-13 1:00 ` [PATCH 1/5] kernel: Move kernel_clone_args's fn to new struct Mike Christie
2023-02-13 3:30 ` kernel test robot
2023-02-13 5:28 ` kernel test robot
2023-02-13 19:57 ` Linus Torvalds
2023-02-13 1:00 ` Mike Christie [this message]
2023-02-13 1:00 ` [PATCH 3/5] io_uring: Convert to use setup_thread_fn callout Mike Christie
2023-02-13 1:00 ` [PATCH 4/5] kernel: Prepare set_kthread_struct to be used for setup_thread_fn Mike Christie
2023-02-13 19:54 ` Linus Torvalds
2023-02-14 0:50 ` Mike Christie
2023-02-14 18:00 ` Linus Torvalds
2023-02-13 1:00 ` [PATCH 5/5] kernel: Convert kthread to use setup_thread_fn Mike Christie
2023-02-13 3:41 ` kernel test robot
2023-02-13 3:41 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230213010020.1813-3-michael.christie@oracle.com \
--to=michael.christie@oracle.com \
--cc=brauner@kernel.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®