From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Rob Herring <robh@kernel.org>, Marc Zyngier <maz@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
Peter Rosin <peda@axentia.se>
Subject: [PATCH 2/3] of: OF_IRQ: select IRQ_DOMAIN instead of depending on it
Date: Sun, 12 Feb 2023 20:15:34 -0800 [thread overview]
Message-ID: <20230213041535.12083-3-rdunlap@infradead.org> (raw)
In-Reply-To: <20230213041535.12083-1-rdunlap@infradead.org>
IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set
it directly thru "make *config", so drivers should select it instead
of depending on it if they need it.
Relying on it being set for a dependency is risky.
Consistently using "select" or "depends on" can also help reduce
Kconfig circular dependency issues.
Therefore, change OF_IRQ's use of "depends on" to "select".
This patch reduces one Kconfig circular dependency in
drivers/mux/Kconfig when MUX_MMIO attempts to select REGMAP, which
that driver needs (but does not completely resolve that issue). [1]
[1] https://lore.kernel.org/lkml/20230210115625.GA30942@pengutronix.de/
Fixes: 63c60e3a6dc3 ("of: OF_IRQ should depend on IRQ_DOMAIN")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Rob Herring <robh@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Peter Rosin <peda@axentia.se>
---
I have a similar patch (should be a series) for REGMAP.
drivers/of/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -- a/drivers/of/Kconfig b/drivers/of/Kconfig
--- a/drivers/of/Kconfig
+++ b/drivers/of/Kconfig
@@ -68,7 +68,8 @@ config OF_ADDRESS
config OF_IRQ
def_bool y
- depends on !SPARC && IRQ_DOMAIN
+ depends on !SPARC
+ select IRQ_DOMAIN
config OF_RESERVED_MEM
def_bool OF_EARLY_FLATTREE
next prev parent reply other threads:[~2023-02-13 4:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 4:15 [PATCH 0/3] IRQ_DOMAIN: remove all "depends on", use only "select" Randy Dunlap
2023-02-13 4:15 ` [PATCH 1/3] extcon: max8997: select IRQ_DOMAIN instead of depending on it Randy Dunlap
2023-02-13 4:15 ` Randy Dunlap [this message]
2023-02-13 4:15 ` [PATCH 3/3] rtc: mt6397: " Randy Dunlap
2023-02-15 14:29 ` AngeloGioacchino Del Regno
2023-02-13 8:05 ` [PATCH 0/3] IRQ_DOMAIN: remove all "depends on", use only "select" Arnd Bergmann
2023-02-14 18:30 ` Randy Dunlap
2023-02-14 19:56 ` Marc Zyngier
2023-02-23 18:37 ` Randy Dunlap
2023-02-28 19:29 ` Marc Zyngier
2023-02-28 23:04 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230213041535.12083-3-rdunlap@infradead.org \
--to=rdunlap@infradead.org \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=peda@axentia.se \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®