mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, andersson@kernel.org,
	agross@kernel.org, krzysztof.kozlowski@linaro.org,
	marijn.suijten@somainline.org, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: power: supply: pm8941-coincell: Don't require charging properties
Date: Mon, 13 Feb 2023 23:45:40 +0100	[thread overview]
Message-ID: <20230213224540.o4fd554ippzdej7a@mercury.elektranox.org> (raw)
In-Reply-To: <83637cc7-21ae-7778-37b3-4522cc0a06c9@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]

Hi,

On Mon, Feb 13, 2023 at 10:41:10PM +0100, Konrad Dybcio wrote:
> On 13.02.2023 22:27, Sebastian Reichel wrote:
> > On Mon, Feb 13, 2023 at 09:49:49PM +0100, Konrad Dybcio wrote:
> >> It's fine for these properties to be absent, as the driver doesn't fail
> >> without them and functions with settings inherited from the reset/previous
> >> stage bootloader state.
> >>
> >> Fixes: 6c463222a21d ("dt-bindings: power: supply: pm8941-coincell: Convert to DT schema format")
> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> >> ---
> > Please update the description of these properties to describe the
> > default behaviour.
> Not sure if there's any default behavior other than "go with
> whatever was there previously, no matter how it got there".

I got that from the patch description, but that behaviour should be
described in the binding.

> Is it okay if I just add:
> 
> "If unspecified, inherit the bootloader configuration"

Technically the bindings are also for bootloaders. I suggest:

If unspecified, inherit the previous configuration (e.g. from
bootloader or hardware default value).

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2023-02-13 22:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-13 20:49 [PATCH 1/3] dt-bindings: power: supply: pm8941-coincell: Add PM8998 compatible Konrad Dybcio
2023-02-13 20:49 ` [PATCH 2/3] dt-bindings: power: supply: pm8941-coincell: Don't require charging properties Konrad Dybcio
2023-02-13 21:27   ` Sebastian Reichel
2023-02-13 21:41     ` Konrad Dybcio
2023-02-13 22:45       ` Sebastian Reichel [this message]
2023-02-13 20:49 ` [PATCH 3/3] arm64: dts: qcom: pm8998: Add a specific compatible for coincell chg Konrad Dybcio
2023-02-14  7:57 ` [PATCH 1/3] dt-bindings: power: supply: pm8941-coincell: Add PM8998 compatible Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230213224540.o4fd554ippzdej7a@mercury.elektranox.org \
    --to=sebastian.reichel@collabora.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®