From: Marijn Suijten <marijn.suijten@somainline.org>
To: Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Archit Taneja <architt@codeaurora.org>,
Chandan Uddaraju <chandanu@codeaurora.org>,
Sravanthi Kollukuduru <skolluku@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Martin Botka <martin.botka@somainline.org>,
Jami Kettunen <jami.kettunen@somainline.org>,
phone-devel@vger.kernel.org,
Marijn Suijten <marijn.suijten@somainline.org>
Subject: [PATCH 2/3] drm/msm/dpu: Drop unused get_scaler_ver callback from SSPP
Date: Thu, 16 Feb 2023 00:02:24 +0100 [thread overview]
Message-ID: <20230215-sspp-scaler-version-v1-2-416b1500b85b@somainline.org> (raw)
In-Reply-To: <20230215-sspp-scaler-version-v1-0-416b1500b85b@somainline.org>
This pointer callback is never used and should be removed. The helper
_dpu_hw_sspp_get_scaler3_ver function is retained as it is being used by
dpu_hw_sspp_init which didn't itself compute _sspp_subblk_offset yet.
Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 4 +---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 6 ------
2 files changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c
index d4e181e1378c..00e5dc2318db 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c
@@ -689,10 +689,8 @@ static void _setup_layer_ops(struct dpu_hw_pipe *c,
if (test_bit(DPU_SSPP_SCALER_QSEED3, &features) ||
test_bit(DPU_SSPP_SCALER_QSEED3LITE, &features) ||
- test_bit(DPU_SSPP_SCALER_QSEED4, &features)) {
+ test_bit(DPU_SSPP_SCALER_QSEED4, &features))
c->ops.setup_scaler = _dpu_hw_sspp_setup_scaler3;
- c->ops.get_scaler_ver = _dpu_hw_sspp_get_scaler3_ver;
- }
if (test_bit(DPU_SSPP_CDP, &features))
c->ops.setup_cdp = dpu_hw_sspp_setup_cdp;
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h
index eeaf16c6af15..bebb62c09dd8 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h
@@ -329,12 +329,6 @@ struct dpu_hw_sspp_ops {
struct dpu_hw_pipe_cfg *pipe_cfg,
void *scaler_cfg);
- /**
- * get_scaler_ver - get scaler h/w version
- * @ctx: Pointer to pipe context
- */
- u32 (*get_scaler_ver)(struct dpu_hw_pipe *ctx);
-
/**
* setup_cdp - setup client driven prefetch
* @ctx: Pointer to pipe context
--
2.39.2
next prev parent reply other threads:[~2023-02-15 23:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 23:02 [PATCH 0/3] drm/msm/dpu: Initialize SSPP scaler version (from register read) Marijn Suijten
2023-02-15 23:02 ` [PATCH 1/3] drm/msm/dpu: Read previously-uninitialized SSPP scaler version from hw Marijn Suijten
2023-02-16 2:22 ` Dmitry Baryshkov
2023-02-16 8:31 ` Marijn Suijten
2023-02-16 16:34 ` Dmitry Baryshkov
2023-02-16 21:46 ` Marijn Suijten
2023-02-17 15:00 ` Dmitry Baryshkov
2023-02-15 23:02 ` Marijn Suijten [this message]
2023-02-16 2:23 ` [PATCH 2/3] drm/msm/dpu: Drop unused get_scaler_ver callback from SSPP Dmitry Baryshkov
2023-02-15 23:02 ` [PATCH 3/3] drm/msm/dpu: Drop unused qseed_type from catalog dpu_caps Marijn Suijten
2023-02-16 2:57 ` Dmitry Baryshkov
2023-02-16 3:02 ` [PATCH 0/3] drm/msm/dpu: Initialize SSPP scaler version (from register read) Dmitry Baryshkov
2023-02-16 9:04 ` Marijn Suijten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230215-sspp-scaler-version-v1-2-416b1500b85b@somainline.org \
--to=marijn.suijten@somainline.org \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@somainline.org \
--cc=architt@codeaurora.org \
--cc=chandanu@codeaurora.org \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jami.kettunen@somainline.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.botka@somainline.org \
--cc=phone-devel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=skolluku@codeaurora.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®