mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Jesper Juhl <jesperjuhl76@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [Patch] [samples/trace_events] Remove unnecessary version.h include pointed out by 'make versioncheck'
Date: Thu, 16 Feb 2023 21:31:13 -0500	[thread overview]
Message-ID: <20230216213113.6c4f59af@rorschach.local.home> (raw)
In-Reply-To: <86718c8a-4a55-7254-f489-9c071588bc25@gmail.com>

On Thu, 16 Feb 2023 02:03:29 +0100 (CET)
Jesper Juhl <jesperjuhl76@gmail.com> wrote:

> >From 8917ba4246c3fa7344523a0c46b793c5dbb0400b Mon Sep 17 00:00:00 2001  
> From: Jesper Juhl <jesperjuhl76@gmail.com>
> Date: Mon, 13 Feb 2023 02:53:37 +0100
> Subject: [PATCH 07/12] [samples/trace_events] Remove unneeded version.h
>   include pointed out by 'make versioncheck'
> 

The subject is not formatted correctly. There's no body to the commit.
And the Signed-off-by tag is incorrect. Not to mention that the patch
itself is corrupted.

Please fix all of these.

-- Steve


> Signed-ogg-by: Jesper Juhl <jesperjuhl76@gmail.com>
> ---
>   samples/trace_events/trace_custom_sched.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/samples/trace_events/trace_custom_sched.c b/samples/trace_events/trace_custom_sched.c
> index b99d9ab7db85..dd409b704b35 100644
> --- a/samples/trace_events/trace_custom_sched.c
> +++ b/samples/trace_events/trace_custom_sched.c
> @@ -8,7 +8,6 @@
>   #define pr_fmt(fmt) fmt
> 
>   #include <linux/trace_events.h>
> -#include <linux/version.h>
>   #include <linux/module.h>
>   #include <linux/sched.h>
> 


      reply	other threads:[~2023-02-17  2:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-16  1:03 Jesper Juhl
2023-02-17  2:31 ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230216213113.6c4f59af@rorschach.local.home \
    --to=rostedt@goodmis.org \
    --cc=jesperjuhl76@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®