From: Li zeming <zeming@nfschina.com>
To: keescook@chromium.org, arnd@arndb.de, gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, Li zeming <zeming@nfschina.com>
Subject: [PATCH] lkdtm: perms: Increase pointer assignment check
Date: Sat, 18 Feb 2023 02:58:01 +0800 [thread overview]
Message-ID: <20230217185801.3232-1-zeming@nfschina.com> (raw)
Increase the check after the pointer allocates memory. If these two
functions are used, at least increase some robustness.
Signed-off-by: Li zeming <zeming@nfschina.com>
---
drivers/misc/lkdtm/perms.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/misc/lkdtm/perms.c b/drivers/misc/lkdtm/perms.c
index b93404d65650..a5d8dce5ce49 100644
--- a/drivers/misc/lkdtm/perms.c
+++ b/drivers/misc/lkdtm/perms.c
@@ -180,15 +180,19 @@ static void lkdtm_EXEC_STACK(void)
static void lkdtm_EXEC_KMALLOC(void)
{
u32 *kmalloc_area = kmalloc(EXEC_SIZE, GFP_KERNEL);
- execute_location(kmalloc_area, CODE_WRITE);
- kfree(kmalloc_area);
+ if (kmalloc_area) {
+ execute_location(kmalloc_area, CODE_WRITE);
+ kfree(kmalloc_area);
+ }
}
static void lkdtm_EXEC_VMALLOC(void)
{
u32 *vmalloc_area = vmalloc(EXEC_SIZE);
- execute_location(vmalloc_area, CODE_WRITE);
- vfree(vmalloc_area);
+ if (vmalloc_area) {
+ execute_location(vmalloc_area, CODE_WRITE);
+ vfree(vmalloc_area);
+ }
}
static void lkdtm_EXEC_RODATA(void)
--
2.18.2
reply other threads:[~2023-02-16 2:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230217185801.3232-1-zeming@nfschina.com \
--to=zeming@nfschina.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®