From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1903DC7EE23 for ; Fri, 24 Feb 2023 19:32:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229720AbjBXTcy (ORCPT ); Fri, 24 Feb 2023 14:32:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229479AbjBXTcv (ORCPT ); Fri, 24 Feb 2023 14:32:51 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A75E71BE6; Fri, 24 Feb 2023 11:32:49 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3631861924; Fri, 24 Feb 2023 19:32:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3F67C433D2; Fri, 24 Feb 2023 19:32:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1677267168; bh=SWkLnlr1tyAWXgS02hR1wX6dMdkFNZ2D757/FbtNjTs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bDflmbhfe6Y+Y0BvHe5JrIppNwxZqwpaF/ivu5jD6/VF4crFi5YO0EB/nYK3DjW72 8Ro0F7aQ3ycdqlqPOneOJX8Ftsj4fIxQkbzsRU289o0jB4VVoLHBM5iwdddRaUO4UK SIaoEH5sBei0t86oHfQ9qs7jBhATK4/am3yzl4Wg= Date: Fri, 24 Feb 2023 11:32:47 -0800 From: Andrew Morton To: Linus Torvalds Cc: Greg Kroah-Hartman , Paul Eggert , Jim Meyering , Nathan Chancellor , Guenter Roeck , stable , patches@lists.linux.dev, Linux Kernel Mailing List , shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, Pavel Machek , Jon Hunter , Florian Fainelli , Sudip Mukherjee , srw@sladewatkins.net, rwarsow@gmx.de Subject: Re: diffutils file mode (was Re: [PATCH 5.15 00/37] 5.15.96-rc2 review) Message-Id: <20230224113247.07a660eb44198499314a9e96@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 24 Feb 2023 11:16:52 -0800 Linus Torvalds wrote: > But as far as I can tell, GNU diffutils have never actually grown the > ability to generate those extensions, even though at least the mode > bit one should be fairly simple (the file rename/copy ones are rather > more complicated, but those are just a "make diffs more legible and > compact" convenience thing, unlike the executable bit thing that > allows for scripts to remain executable). yeah, irritating. Can we use git instead of diff? I tried once, but it didn't work - perhaps because it didn't like doing stuff outside a git repo. However, trying it now... hp2:/home/akpm> mkdir foo hp2:/home/akpm> cd foo hp2:/home/akpm/foo> date > a hp2:/home/akpm/foo> cp a b hp2:/home/akpm/foo> chmod +x a hp2:/home/akpm/foo> git diff a b diff --git a/a b/b old mode 100755 new mode 100644