From: Armin Wolf <W_Armin@gmx.de>
To: rafael@kernel.org, lenb@kernel.org
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/4] ACPI: SBS: Fix various issues
Date: Sat, 25 Feb 2023 09:04:54 +0100 [thread overview]
Message-ID: <20230225080458.1342359-1-W_Armin@gmx.de> (raw)
On my Acer Travelmate 4002WLMi, the system locks up upon
suspend/shutdown. After a lot of research, it turned out
that the sbs module was the culprit. The driver would not
correctly mask out the value used to select a battery using
the "Smart Battery Selector" (subset of the "Smart Battery Manager").
This accidentally caused a invalid power source to be selected,
which was automatically corrected by the selector. Upon
notifing the host about the corrected power source, some batteries
would be selected for re-reading, causing a endless loop.
This would lead to some workqueues filling up, which caused the
lockup upon suspend/shutdown.
The first three patches fix a stacktrace on module removal caused
by some locking issues. The last patch finally fixes the
suspend/shutdown issues.
As a side note: This was the first machine on which i installed Linux,
to finally fixing this took ~5 years of tinkering.
Armin Wolf (4):
ACPI: EC: Add query notifier support
ACPI: sbshc: Use ec query notifier call chain
ACPI: EC: Make query handlers private
ACPI: SBS: Fix handling of Smart Battery Selectors
drivers/acpi/ec.c | 44 ++++++++++++++++++++--------------------
drivers/acpi/internal.h | 10 ++++-----
drivers/acpi/sbs.c | 27 ++++++++++++++++---------
drivers/acpi/sbshc.c | 45 ++++++++++++++++++++++++++---------------
4 files changed, 74 insertions(+), 52 deletions(-)
--
2.30.2
next reply other threads:[~2023-02-25 8:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-25 8:04 Armin Wolf [this message]
2023-02-25 8:04 ` [PATCH 1/4] ACPI: EC: Add query notifier support Armin Wolf
2023-02-25 8:04 ` [PATCH 2/4] ACPI: sbshc: Use ec query notifier call chain Armin Wolf
2023-02-25 8:04 ` [PATCH 3/4] ACPI: EC: Make query handlers private Armin Wolf
2023-02-25 10:32 ` kernel test robot
2023-02-25 10:53 ` kernel test robot
2023-02-25 11:03 ` kernel test robot
2023-02-25 8:04 ` [PATCH 4/4] ACPI: SBS: Fix handling of Smart Battery Selectors Armin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230225080458.1342359-1-W_Armin@gmx.de \
--to=w_armin@gmx.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®