From: Guenter Roeck <linux@roeck-us.net>
To: Tony O'Brien <tony.obrien@alliedtelesis.co.nz>
Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org,
chris.packham@alliedtelesis.co.nz, hdegoede@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] hwmon: (adt7475) Fix masking of hysteresis registers
Date: Sat, 25 Feb 2023 07:03:09 -0800 [thread overview]
Message-ID: <20230225150309.GA3647996@roeck-us.net> (raw)
In-Reply-To: <20230222005228.158661-3-tony.obrien@alliedtelesis.co.nz>
On Wed, Feb 22, 2023 at 01:52:28PM +1300, Tony O'Brien wrote:
> The wrong bits are masked in the hysteresis register; indices 0 and 2
> should zero bits [7:4] and preserve bits [3:0], and index 1 should zero
> bits [3:0] and preserve bits [7:4].
>
> Fixes: 1c301fc5394f ("hwmon: Add a driver for the ADT7475 hardware monitoring chip")
> Signed-off-by: Tony O'Brien <tony.obrien@alliedtelesis.co.nz>
Applied.
Thanks,
Guenter
prev parent reply other threads:[~2023-02-25 15:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 0:52 [PATCH v2 0/2] hwmon: (adt7475) Fixes for acoustics and hysteresis Tony O'Brien
2023-02-22 0:52 ` [PATCH v2 1/2] hwmon: (adt7475) Display smoothing attributes in correct order Tony O'Brien
2023-02-25 15:02 ` Guenter Roeck
2023-02-22 0:52 ` [PATCH v2 2/2] hwmon: (adt7475) Fix masking of hysteresis registers Tony O'Brien
2023-02-25 15:03 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230225150309.GA3647996@roeck-us.net \
--to=linux@roeck-us.net \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=hdegoede@redhat.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.obrien@alliedtelesis.co.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®