mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Santosh Shukla <santosh.shukla@amd.com>
To: <kvm@vger.kernel.org>, <seanjc@google.com>
Cc: <pbonzini@redhat.com>, <jmattson@google.com>, <joro@8bytes.org>,
	<linux-kernel@vger.kernel.org>, <mail@maciej.szmigiero.name>,
	<mlevitsk@redhat.com>, <thomas.lendacky@amd.com>,
	<vkuznets@redhat.com>
Subject: [PATCHv3 04/10] KVM: x86: Raise an event request when processing NMIs if an NMI is pending
Date: Mon, 27 Feb 2023 09:23:54 +0530	[thread overview]
Message-ID: <20230227035400.1498-5-santosh.shukla@amd.com> (raw)
In-Reply-To: <20230227035400.1498-1-santosh.shukla@amd.com>

From: Sean Christopherson <seanjc@google.com>

Don't raise KVM_REQ_EVENT if no NMIs are pending at the end of
process_nmi().  Finishing process_nmi() without a pending NMI will become
much more likely when KVM gains support for AMD's vNMI, which allows
pending vNMIs in hardware, i.e. doesn't require explicit injection.

Signed-off-by: Sean Christopherson <seanjc@google.com>
Signed-off-by: Santosh Shukla <Santosh.Shukla@amd.com>
---
v3:
- renamed iret_intercept API
https://lore.kernel.org/all/a5d8307b-ffe6-df62-5e22-dffd19755baa@amd.com/

 arch/x86/kvm/x86.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index f706621c35b8..1cd9cadc82af 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -10148,7 +10148,9 @@ static void process_nmi(struct kvm_vcpu *vcpu)
 
 	vcpu->arch.nmi_pending += atomic_xchg(&vcpu->arch.nmi_queued, 0);
 	vcpu->arch.nmi_pending = min(vcpu->arch.nmi_pending, limit);
-	kvm_make_request(KVM_REQ_EVENT, vcpu);
+
+	if (vcpu->arch.nmi_pending)
+		kvm_make_request(KVM_REQ_EVENT, vcpu);
 }
 
 void kvm_make_scan_ioapic_request_mask(struct kvm *kvm,
-- 
2.25.1


  parent reply	other threads:[~2023-02-27  3:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-27  3:53 [PATCHv3 00/10] SVM: virtual NMI Santosh Shukla
2023-02-27  3:53 ` [PATCHv3 01/10] KVM: nSVM: Disable intercept of VINTR if saved RFLAG.IF is 0 Santosh Shukla
2023-02-27  3:53 ` [PATCHv3 02/10] KVM: nSVM: Raise event on nested VM exit if L1 doesn't intercept IRQs Santosh Shukla
2023-02-27  3:53 ` [PATCHv3 03/10] KVM: SVM: add wrappers to enable/disable IRET interception Santosh Shukla
2023-02-27  3:53 ` Santosh Shukla [this message]
2023-02-27  3:53 ` [PATCHv3 05/10] KVM: x86: Tweak the code and comment related to handling concurrent NMIs Santosh Shukla
2023-02-27  3:53 ` [PATCHv3 06/10] KVM: x86: Save/restore all NMIs when multiple NMIs are pending Santosh Shukla
2023-02-27  3:53 ` [PATCHv3 07/10] x86/cpu: Add CPUID feature bit for VNMI Santosh Shukla
2023-02-27  3:53 ` [PATCHv3 08/10] KVM: SVM: Add VNMI bit definition Santosh Shukla
2023-02-27  3:53 ` [PATCHv3 09/10] KVM: x86: add support for delayed virtual NMI injection interface Santosh Shukla
2023-02-27  3:54 ` [PATCHv3 10/10] KVM: nSVM: implement support for nested VNMI Santosh Shukla
2023-02-27  4:47 ` [PATCHv3 00/10] SVM: virtual NMI Santosh Shukla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230227035400.1498-5-santosh.shukla@amd.com \
    --to=santosh.shukla@amd.com \
    --cc=jmattson@google.com \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mail@maciej.szmigiero.name \
    --cc=mlevitsk@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=thomas.lendacky@amd.com \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®