From: Yuanzhi Wang <wangyuanzhi@uniontech.com>
To: alexander.deucher@amd.com, christian.koenig@amd.com,
Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
mario.limonciello@amd.com, Bokun.Zhang@amd.com,
tzimmermann@suse.de, hdegoede@redhat.com, jingyuwang_vip@163.com,
rafael.j.wysocki@intel.com, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: Yuanzhi Wang <wangyuanzhi@uniontech.com>
Subject: [PATCH] amdgpu: add a filter condition when set brightness
Date: Mon, 27 Feb 2023 15:39:53 +0800 [thread overview]
Message-ID: <20230227073953.326-1-wangyuanzhi@uniontech.com> (raw)
When the laptop is plugged into AC or DC power supply,
the brightness obtained ACPI may be smaller than current
brightness.As a result the screen becomes dark,this is
not what people want.
Signed-off-by: Yuanzhi Wang <wangyuanzhi@uniontech.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
index d4196fcb85a0..93f1567028c5 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
@@ -406,6 +406,7 @@ static int amdgpu_atif_handler(struct amdgpu_device *adev,
{
struct amdgpu_atif *atif = &amdgpu_acpi_priv.atif;
int count;
+ int old_brightness;
DRM_DEBUG_DRIVER("event, device_class = %s, type = %#x\n",
event->device_class, event->type);
@@ -443,7 +444,13 @@ static int amdgpu_atif_handler(struct amdgpu_device *adev,
* hardwired to post BACKLIGHT_UPDATE_SYSFS.
* It probably should accept 'reason' parameter.
*/
- backlight_device_set_brightness(atif->bd, req.backlight_level);
+ old_brightness = backlight_get_brightness(atif->bd);
+ if (old_brightness > req.backlight_level)
+ DRM_WARN("old brightness %d is greater than ACPI brightness
+ %d\n", old_brightness, req.backlight_level);
+ else
+ backlight_device_set_brightness(atif->bd,
+ req.backlight_level);
}
}
--
2.20.1
next reply other threads:[~2023-02-27 7:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 7:39 Yuanzhi Wang [this message]
2023-02-27 10:12 ` kernel test robot
2023-02-27 12:18 ` kernel test robot
2023-02-27 13:44 ` kernel test robot
2023-02-27 14:20 ` Mario Limonciello
2023-02-28 3:50 ` wangyuanzhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230227073953.326-1-wangyuanzhi@uniontech.com \
--to=wangyuanzhi@uniontech.com \
--cc=Bokun.Zhang@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=jingyuwang_vip@163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=rafael.j.wysocki@intel.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®