From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
kernel test robot <lkp@intel.com>,
oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: vmlinux.o: warning: objtool: mptscsih_abort+0x7f4: unreachable instruction
Date: Mon, 27 Feb 2023 07:13:28 -0800 [thread overview]
Message-ID: <20230227151328.lyvzzn7kggaa2t5z@treble> (raw)
In-Reply-To: <Y/y5aucdGL7U+W7a@hirez.programming.kicks-ass.net>
On Mon, Feb 27, 2023 at 03:08:42PM +0100, Peter Zijlstra wrote:
> On Mon, Feb 27, 2023 at 12:38:13PM +0000, Mark Rutland wrote:
> > [adding Peter and Josh, given objtool]
> >
> > On Mon, Feb 27, 2023 at 05:28:53PM +0800, kernel test robot wrote:
> > > Hi Mark,
> > >
> > > FYI, the error/warning still remains.
> > >
> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > > head: f3a2439f20d918930cc4ae8f76fe1c1afd26958f
> > > commit: c27cd083cfb9d392f304657ed00fcde1136704e7 Compiler attributes: GCC cold function alignment workarounds
> > > date: 5 weeks ago
> > > config: x86_64-randconfig-r026-20230227 (https://download.01.org/0day-ci/archive/20230227/202302271743.78emit6I-lkp@intel.com/config)
> > > compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
> > > reproduce (this is a W=1 build):
> > > # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c27cd083cfb9d392f304657ed00fcde1136704e7
> > > git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> > > git fetch --no-tags linus master
> > > git checkout c27cd083cfb9d392f304657ed00fcde1136704e7
> > > # save the config file
> > > mkdir build_dir && cp config build_dir/.config
> > > make W=1 O=build_dir ARCH=x86_64 olddefconfig
> > > make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
> > >
> > > If you fix the issue, kindly add following tag where applicable
> > > | Reported-by: kernel test robot <lkp@intel.com>
> > > | Link: https://lore.kernel.org/oe-kbuild-all/202302271743.78emit6I-lkp@intel.com/
> > >
> > > All warnings (new ones prefixed by >>):
> > >
> > > >> vmlinux.o: warning: objtool: mptscsih_abort+0x7f4: unreachable instruction
>
> > > 07ef 2fb7bff: e8 00 00 00 00 call 2fb7c04 <mptscsih_abort+0x7f4> 2fb7c00: R_X86_64_PLT32 mpt_halt_firmware-0x4
> > > 07f4 2fb7c04: e9 75 fb ff ff jmp 2fb777e <mptscsih_abort+0x36e>
>
> this is one of those noreturn things again... objtool was clever enough
> to figure out that mpt_halt_firmware() does not return (all it's control
> flow ends in panic()) and hence it 'knows' that +7f4 will not be
> executed. But GCC didn't figure out the same.
I can take care of this one, to go with my other two piles of noreturn
fixes for after the merge window.
--
Josh
prev parent reply other threads:[~2023-02-27 15:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 9:28 kernel test robot
2023-02-27 12:38 ` Mark Rutland
2023-02-27 14:08 ` Peter Zijlstra
2023-02-27 15:13 ` Josh Poimboeuf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230227151328.lyvzzn7kggaa2t5z@treble \
--to=jpoimboe@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mark.rutland@arm.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®