mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nick Alcock <nick.alcock@oracle.com>
To: mcgrof@kernel.org
Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
	Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Subject: [PATCH 08/17] lib: remove MODULE_LICENSE in non-modules
Date: Thu,  2 Mar 2023 21:17:50 +0000	[thread overview]
Message-ID: <20230302211759.30135-9-nick.alcock@oracle.com> (raw)
In-Reply-To: <20230302211759.30135-1-nick.alcock@oracle.com>

Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So remove it in the files in this commit, none of which can be built as
modules.

Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
---
 lib/glob.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/glob.c b/lib/glob.c
index 15b73f490720c..5c30606a1b92e 100644
--- a/lib/glob.c
+++ b/lib/glob.c
@@ -7,7 +7,6 @@
  * both usually compiled in and the module overhead goes away.
  */
 MODULE_DESCRIPTION("glob(7) matching");
-MODULE_LICENSE("Dual MIT/GPL");
 
 /**
  * glob_match - Shell-style pattern matching, like !fnmatch(pat, str, 0)
-- 
2.39.1.268.g9de2f9a303


  parent reply	other threads:[~2023-03-02 22:20 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-02 21:17 [PATCH 00/17] MODULE_LICENSE removals, sixth tranche Nick Alcock
2023-03-02 21:17 ` [PATCH 01/17] irqchip: remove MODULE_LICENSE in non-modules Nick Alcock
2023-03-02 21:17 ` [PATCH 02/17] bus: " Nick Alcock
2023-03-02 21:17 ` [PATCH 03/17] braille_console: " Nick Alcock
2023-03-02 21:17 ` [PATCH 04/17] arm-cci: " Nick Alcock
2023-03-02 21:17 ` [PATCH 05/17] drivers: bus: simple-pm-bus: " Nick Alcock
2023-03-03  7:52   ` Geert Uytterhoeven
2023-03-03 18:32     ` Nick Alcock
2023-03-03 18:43       ` Geert Uytterhoeven
2023-03-20 10:58     ` Nick Alcock
2023-03-02 21:17 ` [PATCH 06/17] watch_queue: " Nick Alcock
2023-03-02 21:17 ` [PATCH 07/17] btree: " Nick Alcock
2023-03-02 21:17 ` Nick Alcock [this message]
2023-03-02 21:17 ` [PATCH 09/17] fprobe: " Nick Alcock
2023-03-02 21:17 ` [PATCH 10/17] tty: " Nick Alcock
2023-03-09 16:15   ` Greg Kroah-Hartman
2023-03-09 22:38     ` Luis Chamberlain
2023-03-10  7:31       ` Greg Kroah-Hartman
2023-03-10 19:33         ` Luis Chamberlain
2023-03-24  9:08           ` Geert Uytterhoeven
2023-03-24  9:12             ` Geert Uytterhoeven
2023-03-24  9:14             ` Greg Kroah-Hartman
2023-03-24  9:16               ` Geert Uytterhoeven
2023-03-24 14:16                 ` Nick Alcock
2023-03-24 14:29                   ` Greg Kroah-Hartman
2023-03-24 18:06                     ` Luis Chamberlain
2023-03-27 10:46                       ` Nick Alcock
2023-03-27 11:43                         ` Greg Kroah-Hartman
2023-03-27 14:54                           ` Nick Alcock
2023-03-27 18:23                             ` Nick Alcock
2023-03-29  2:50                               ` Luis Chamberlain
2023-04-13 20:24                       ` Luis Chamberlain
2023-03-26  4:52               ` Christoph Hellwig
2023-03-02 21:17 ` [PATCH 11/17] unicode: " Nick Alcock
2023-03-06 15:32   ` Gabriel Krisman Bertazi
2023-03-02 21:17 ` [PATCH 12/17] udmabuf: " Nick Alcock
2023-03-02 21:17 ` [PATCH 13/17] regulator: stm32-pwr: " Nick Alcock
2023-03-03  0:31   ` Mark Brown
2023-03-03 18:30     ` Nick Alcock
2023-03-04 20:12       ` Mark Brown
2023-03-02 21:17 ` [PATCH 14/17] mm: " Nick Alcock
2023-03-02 21:17 ` [PATCH 15/17] xen: " Nick Alcock
2023-03-06  7:45   ` Juergen Gross
2023-03-02 21:17 ` [PATCH 16/17] zpool: " Nick Alcock
2023-03-02 21:17 ` [PATCH 17/17] zswap: " Nick Alcock
2023-03-03 22:22 ` [PATCH 00/17] MODULE_LICENSE removals, sixth tranche Luis Chamberlain
2023-03-20 11:00   ` Nick Alcock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230302211759.30135-9-nick.alcock@oracle.com \
    --to=nick.alcock@oracle.com \
    --cc=hasegawa-hitomi@fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®