From: Jan Kara <jack@suse.cz>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Jan Kara <jack@suse.cz>,
"Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
Jan Kara <jack@suse.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [git pull] vfs.git sysv pile
Date: Fri, 3 Mar 2023 10:24:57 +0100 [thread overview]
Message-ID: <20230303092457.knxeiofnv6vxbazw@quack3> (raw)
In-Reply-To: <ZAD4bNDEIZf/VAnh@ZenIV>
On Thu 02-03-23 19:26:36, Al Viro wrote:
> On Thu, Mar 02, 2023 at 10:59:31AM +0100, Jan Kara wrote:
> > OK, I think your changes to ext2_rename() in PATCH 1 leak a reference and
> > mapping of old_page
>
> In which case? ext2_delete_entry() failing?
>
> - ext2_delete_entry(old_de, old_page, old_page_addr);
> + err = ext2_delete_entry(old_de, old_page, old_page_addr);
> + if (err)
> + goto out_dir;
>
> and on out_dir: we have
> out_dir:
> if (dir_de)
> ext2_put_page(dir_page, dir_page_addr);
> out_old:
> ext2_put_page(old_page, old_page_addr);
> out:
> return err;
>
> How is the old_page leaked here?
Ah, sorry, I got confused by the diff. Now that I'm looking into the full
source, it's all fine. Sorry for the noise.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2023-03-03 9:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 3:26 Al Viro
2023-02-25 3:40 ` pr-tracker-bot
2023-03-01 11:20 ` Fabio M. De Francesco
2023-03-01 13:00 ` Jan Kara
2023-03-01 13:21 ` Fabio M. De Francesco
2023-03-01 14:14 ` Al Viro
2023-03-02 9:59 ` Jan Kara
2023-03-02 11:31 ` Fabio M. De Francesco
2023-03-02 19:35 ` Al Viro
2023-03-02 22:35 ` Al Viro
2023-03-03 5:10 ` Fabio M. De Francesco
2023-03-03 4:58 ` Fabio M. De Francesco
2023-03-08 17:40 ` Fabio M. De Francesco
2023-03-09 13:45 ` Fabio M. De Francesco
2023-03-02 19:26 ` Al Viro
2023-03-03 9:24 ` Jan Kara [this message]
2023-03-15 18:08 ` Fabio M. De Francesco
2023-03-16 9:00 ` Jan Kara
2023-03-16 10:30 ` Fabio M. De Francesco
2023-03-20 11:18 ` Fabio M. De Francesco
2023-03-20 12:47 ` Jan Kara
2023-03-27 10:29 ` Fabio M. De Francesco
2023-05-25 20:10 ` Jan Kara
2023-05-26 10:32 ` Fabio M. De Francesco
2023-05-26 13:25 ` Fabio M. De Francesco
2023-05-29 9:02 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230303092457.knxeiofnv6vxbazw@quack3 \
--to=jack@suse.cz \
--cc=fmdefrancesco@gmail.com \
--cc=jack@suse.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®