mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: "Jan Dąbroś" <jsd@semihalf.com>,
	"Grzegorz Bernacki" <gjb@semihalf.com>,
	Rijo-john.Thomas@amd.com, Thomas.Lendacky@amd.com,
	herbert@gondor.apana.org.au,
	"Jarkko Nikula" <jarkko.nikula@linux.intel.com>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Mika Westerberg" <mika.westerberg@linux.intel.com>
Cc: Mario Limonciello <mario.limonciello@amd.com>,
	<linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v3 8/9] i2c: designware: Add doorbell support for Skyrim
Date: Fri, 3 Mar 2023 10:50:46 -0600	[thread overview]
Message-ID: <20230303165050.2918-9-mario.limonciello@amd.com> (raw)
In-Reply-To: <20230303165050.2918-1-mario.limonciello@amd.com>

Skyrim doesn't use the platform feature mailbox for communication
for I2C arbitration, it relies upon ringing a doorbell.

Link: https://lore.kernel.org/linux-i2c/20220916131854.687371-3-jsd@semihalf.com/
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
v2->v3:
 * Use CPU ID rather than ACPI ID, this will be pushed to a later patch
v1->v2:
 * New patch

doorbell; get status field
---
 drivers/i2c/busses/i2c-designware-amdpsp.c | 28 ++++++++++++++--------
 1 file changed, 18 insertions(+), 10 deletions(-)

diff --git a/drivers/i2c/busses/i2c-designware-amdpsp.c b/drivers/i2c/busses/i2c-designware-amdpsp.c
index 105584abcf8f..2c671973010d 100644
--- a/drivers/i2c/busses/i2c-designware-amdpsp.c
+++ b/drivers/i2c/busses/i2c-designware-amdpsp.c
@@ -73,34 +73,43 @@ static int psp_send_check_i2c_req(struct psp_i2c_req *req)
 	return check_i2c_req_sts(req);
 }
 
-static int psp_send_i2c_req(enum psp_i2c_req_type i2c_req_type)
+static int psp_send_i2c_req_amdi0019(enum psp_i2c_req_type i2c_req_type)
 {
 	struct psp_i2c_req *req;
-	unsigned long start;
 	int status, ret;
 
 	/* Allocate command-response buffer */
 	req = kzalloc(sizeof(*req), GFP_KERNEL);
 	if (!req)
 		return -ENOMEM;
-
 	req->hdr.payload_size = sizeof(*req);
 	req->type = i2c_req_type;
-
-	start = jiffies;
 	ret = read_poll_timeout(psp_send_check_i2c_req, status,
 				(status != -EBUSY),
 				PSP_I2C_REQ_RETRY_DELAY_US,
 				PSP_I2C_REQ_RETRY_CNT * PSP_I2C_REQ_RETRY_DELAY_US,
 				0, req);
-	if (ret) {
+	kfree(req);
+
+	if (ret)
 		dev_err(psp_i2c_dev, "Timed out waiting for PSP to %s I2C bus\n",
 			(i2c_req_type == PSP_I2C_REQ_ACQUIRE) ?
 			"release" : "acquire");
-		goto cleanup;
-	}
 
-	ret = status;
+	return ret ? ret : status;
+}
+
+static int psp_send_i2c_req(enum psp_i2c_req_type i2c_req_type)
+{
+	unsigned long start = jiffies;
+	int ret;
+
+	/* Use doorbell for Skyrim and mailbox for Cezanne */
+	if (boot_cpu_data.x86 == 25 && boot_cpu_data.x86_model == 80)
+		ret = psp_send_i2c_req_amdi0019(i2c_req_type);
+	else
+		ret = psp_ring_platform_doorbell(i2c_req_type);
+
 	if (ret) {
 		dev_err(psp_i2c_dev, "PSP communication error\n");
 		goto cleanup;
@@ -115,7 +124,6 @@ static int psp_send_i2c_req(enum psp_i2c_req_type i2c_req_type)
 		psp_i2c_mbox_fail = true;
 	}
 
-	kfree(req);
 	return ret;
 }
 
-- 
2.34.1


  parent reply	other threads:[~2023-03-03 16:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-03 16:50 [PATCH v3 0/9] Export platform features from ccp driver Mario Limonciello
2023-03-03 16:50 ` [PATCH v3 1/9] crypto: ccp: Drop TEE support for IRQ handler Mario Limonciello
2023-03-03 16:50 ` [PATCH v3 2/9] crypto: ccp: Add a header for multiple drivers to use `__psp_pa` Mario Limonciello
2023-03-07 23:42   ` Sean Christopherson
2023-03-03 16:50 ` [PATCH v3 3/9] crypto: ccp: Move some PSP mailbox bit definitions into common header Mario Limonciello
2023-03-03 16:50 ` [PATCH v3 4/9] crypto: ccp: Add support for an interface for platform features Mario Limonciello
2023-03-03 16:50 ` [PATCH v3 5/9] crypto: ccp: Enable platform access interface on client PSP parts Mario Limonciello
2023-03-03 16:50 ` [PATCH v3 6/9] i2c: designware: Use PCI PSP driver for communication Mario Limonciello
2023-03-03 16:50 ` [PATCH v3 7/9] crypto: ccp: Add support for ringing a platform doorbell Mario Limonciello
2023-03-10 11:19   ` Herbert Xu
2023-03-03 16:50 ` Mario Limonciello [this message]
2023-03-03 16:50 ` [PATCH v3 9/9] i2c: designware: Add support for AMDI0020 ACPI ID Mario Limonciello
2023-03-06 12:04   ` Andy Shevchenko
2023-03-06 12:28     ` Jarkko Nikula
2023-03-06 12:55       ` Andy Shevchenko
2023-03-06 13:11         ` Mario Limonciello
2023-03-07 21:22           ` Limonciello, Mario
2023-03-03 20:58 ` [PATCH v3 0/9] Export platform features from ccp driver Tom Lendacky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230303165050.2918-9-mario.limonciello@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=Rijo-john.Thomas@amd.com \
    --cc=Thomas.Lendacky@amd.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=gjb@semihalf.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=jsd@semihalf.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®