From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FB4EC61DA4 for ; Fri, 3 Mar 2023 22:32:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232363AbjCCWcB (ORCPT ); Fri, 3 Mar 2023 17:32:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232124AbjCCWbp (ORCPT ); Fri, 3 Mar 2023 17:31:45 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9121265C50; Fri, 3 Mar 2023 14:26:54 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 802D2CE2294; Fri, 3 Mar 2023 21:49:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CB44C433EF; Fri, 3 Mar 2023 21:49:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677880160; bh=B7NTi1FdHIGrYvLYxcYK2kZHRMsFpemC0yukXnWPFno=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=O80De6L0BHpZ5yW4E8P/2TUIC3/QIY5q1UW661hfjv+VC7fzEE9XiRJqONilwR+Ul j4KMu5TkD3QVBafGmO2aiRLMelkFx4l4wBOgw8FxzgPKLt3JQDjxkZQDwQkgK4hqLk YbfVti3y32kee0fbNsvD2gCmk33c9kKjHylUUEwwLpiozKTuFnYdx4ZxzhTK8UVdaB weZsLeNAMmvaEvnh8+tA5FmzhPEX1T7hb+oLomnhISk9arto2lob+wvXPCZcTNC/O5 W1KSWvvHRelpJxcc0ca/MqyCz9yLp/abEaReI1uY4fOd4KNFJyQCAmKenyFlx5qMVv 1SGk9oXWGpCWQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Harshit Mogalapalli , Jonathan Cameron , Sasha Levin , jic23@kernel.org, linux-iio@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 11/16] iio: accel: mma9551_core: Prevent uninitialized variable in mma9551_read_config_word() Date: Fri, 3 Mar 2023 16:48:44 -0500 Message-Id: <20230303214849.1454002-11-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230303214849.1454002-1-sashal@kernel.org> References: <20230303214849.1454002-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Harshit Mogalapalli [ Upstream commit 64a68158738ec8f520347144352f7a09bdb9e169 ] Smatch Warns: drivers/iio/accel/mma9551_core.c:299 mma9551_read_config_word() error: uninitialized symbol 'v'. When (offset >= 1 << 12) is true mma9551_transfer() will return -EINVAL without 'v' being initialized, so check for the error and return. Note: No actual bug as caller checks the return value and does not use the parameter in the problem case. Signed-off-by: Harshit Mogalapalli Link: https://lore.kernel.org/r/20230126153610.3586243-1-harshit.m.mogalapalli@oracle.com Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/iio/accel/mma9551_core.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/iio/accel/mma9551_core.c b/drivers/iio/accel/mma9551_core.c index b4bbc83be4310..19b4fbc682e63 100644 --- a/drivers/iio/accel/mma9551_core.c +++ b/drivers/iio/accel/mma9551_core.c @@ -304,9 +304,12 @@ int mma9551_read_config_word(struct i2c_client *client, u8 app_id, ret = mma9551_transfer(client, app_id, MMA9551_CMD_READ_CONFIG, reg, NULL, 0, (u8 *)&v, 2); + if (ret < 0) + return ret; + *val = be16_to_cpu(v); - return ret; + return 0; } EXPORT_SYMBOL(mma9551_read_config_word); -- 2.39.2