From: Tom Rix <trix@redhat.com>
To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, hpa@zytor.com, mhiramat@kernel.org,
yangjihong1@huawei.com, ast@kernel.org, peterz@infradead.org
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Tom Rix <trix@redhat.com>
Subject: [PATCH] x86/kprobes: remove extern from arch_unoptimized_kprobes
Date: Sat, 4 Mar 2023 09:15:44 -0500 [thread overview]
Message-ID: <20230304141544.1936934-1-trix@redhat.com> (raw)
smatch reports
arch/x86/kernel/kprobes/opt.c:537:13: warning:
function 'arch_unoptimize_kprobes' with external linkage has definition
extern is only needed in a declaration, so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
arch/x86/kernel/kprobes/opt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/kprobes/opt.c b/arch/x86/kernel/kprobes/opt.c
index 57b0037d0a99..1e699deb77fe 100644
--- a/arch/x86/kernel/kprobes/opt.c
+++ b/arch/x86/kernel/kprobes/opt.c
@@ -534,8 +534,8 @@ void arch_unoptimize_kprobe(struct optimized_kprobe *op)
* Recover original instructions and breakpoints from relative jumps.
* Caller must call with locking kprobe_mutex.
*/
-extern void arch_unoptimize_kprobes(struct list_head *oplist,
- struct list_head *done_list)
+void arch_unoptimize_kprobes(struct list_head *oplist,
+ struct list_head *done_list)
{
struct optimized_kprobe *op, *tmp;
--
2.27.0
next reply other threads:[~2023-03-04 14:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-04 14:15 Tom Rix [this message]
2023-03-06 2:30 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230304141544.1936934-1-trix@redhat.com \
--to=trix@redhat.com \
--cc=ast@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yangjihong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®