From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D2EDC678DB for ; Sun, 5 Mar 2023 14:04:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230307AbjCEOEH (ORCPT ); Sun, 5 Mar 2023 09:04:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230079AbjCEOEB (ORCPT ); Sun, 5 Mar 2023 09:04:01 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A96EC166DA; Sun, 5 Mar 2023 06:03:28 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 93A6160B38; Sun, 5 Mar 2023 13:55:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 411A9C4339E; Sun, 5 Mar 2023 13:55:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678024541; bh=NuTpthAViYLX75DXcMpR+bp+WWg0hyyC4BceKqaMtZ4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Aa8tRE831gihJ5b5iRSbhv2QbntBY3mIa5A/dxmEPkJX8YWuf3R1mAfY12L/9zjRd TDEb86vjrJdGSmSdF9WnfSqZZ3c9UctxnS39URnDZ/hAu3C0Gy75NM7JfZ7e7QqgTo vXcvDc7ndIx+OLSDAOyUF/fNX/OlCQiOxLNeDAMOnlsvPty7TGY2fV5S9IecsWD/XV LlsMaFkhUuVq6MfEXJmv+qzng5euH1MCraA7o6zolaHl5aB3FCAJXjm8SvNCbiubNl TZHvszPW8DyDfOG4kNcH5nlVmpx7TLcNKKnTmGZCeSVYloaUh7N8ByktF/UPsTzQSg e/VGUKtQzHhLg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alvaro Karsz , Bjorn Helgaas , "Michael S . Tsirkin" , Sasha Levin , linux-pci@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 6/6] PCI: Avoid FLR for SolidRun SNET DPU rev 1 Date: Sun, 5 Mar 2023 08:55:25 -0500 Message-Id: <20230305135525.1794277-6-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230305135525.1794277-1-sashal@kernel.org> References: <20230305135525.1794277-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alvaro Karsz [ Upstream commit d089d69cc1f824936eeaa4fa172f8fa1a0949eaa ] This patch fixes a FLR bug on the SNET DPU rev 1 by setting the PCI_DEV_FLAGS_NO_FLR_RESET flag. As there is a quirk to avoid FLR (quirk_no_flr), I added a new quirk to check the rev ID before calling to quirk_no_flr. Without this patch, a SNET DPU rev 1 may hang when FLR is applied. Signed-off-by: Alvaro Karsz Acked-by: Bjorn Helgaas Message-Id: <20230110165638.123745-3-alvaro.karsz@solid-run.com> Signed-off-by: Michael S. Tsirkin Signed-off-by: Sasha Levin --- drivers/pci/quirks.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 0a116359b5c71..9a1b0c147983e 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -5067,6 +5067,14 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_AMD, 0x149c, quirk_no_flr); DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x1502, quirk_no_flr); DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x1503, quirk_no_flr); +/* FLR may cause the SolidRun SNET DPU (rev 0x1) to hang */ +static void quirk_no_flr_snet(struct pci_dev *dev) +{ + if (dev->revision == 0x1) + quirk_no_flr(dev); +} +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SOLIDRUN, 0x1000, quirk_no_flr_snet); + static void quirk_no_ext_tags(struct pci_dev *pdev) { struct pci_host_bridge *bridge = pci_find_host_bridge(pdev->bus); -- 2.39.2