From: Andrzej Hajda <andrzej.hajda@intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
Andi Shyti <andi.shyti@linux.intel.com>,
Chris Wilson <chris.p.wilson@linux.intel.com>,
Nirmoy Das <nirmoy.das@intel.com>,
Andrzej Hajda <andrzej.hajda@intel.com>
Subject: [PATCH v5 3/4] drm/i915/selftests: use nop_clear_range instead of local function
Date: Wed, 08 Mar 2023 16:39:05 +0100 [thread overview]
Message-ID: <20230308-guard_error_capture-v5-3-6d1410d13540@intel.com> (raw)
In-Reply-To: <20230308-guard_error_capture-v5-0-6d1410d13540@intel.com>
Since nop_clear_range is visible it can be used here.
Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
drivers/gpu/drm/i915/selftests/mock_gtt.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/selftests/mock_gtt.c b/drivers/gpu/drm/i915/selftests/mock_gtt.c
index ece97e4faacb97..89119e3970279f 100644
--- a/drivers/gpu/drm/i915/selftests/mock_gtt.c
+++ b/drivers/gpu/drm/i915/selftests/mock_gtt.c
@@ -57,11 +57,6 @@ static void mock_cleanup(struct i915_address_space *vm)
{
}
-static void mock_clear_range(struct i915_address_space *vm,
- u64 start, u64 length)
-{
-}
-
struct i915_ppgtt *mock_ppgtt(struct drm_i915_private *i915, const char *name)
{
struct i915_ppgtt *ppgtt;
@@ -80,7 +75,7 @@ struct i915_ppgtt *mock_ppgtt(struct drm_i915_private *i915, const char *name)
ppgtt->vm.alloc_pt_dma = alloc_pt_dma;
ppgtt->vm.alloc_scratch_dma = alloc_pt_dma;
- ppgtt->vm.clear_range = mock_clear_range;
+ ppgtt->vm.clear_range = nop_clear_range;
ppgtt->vm.insert_page = mock_insert_page;
ppgtt->vm.insert_entries = mock_insert_entries;
ppgtt->vm.cleanup = mock_cleanup;
@@ -119,7 +114,7 @@ void mock_init_ggtt(struct intel_gt *gt)
ggtt->vm.alloc_pt_dma = alloc_pt_dma;
ggtt->vm.alloc_scratch_dma = alloc_pt_dma;
- ggtt->vm.clear_range = mock_clear_range;
+ ggtt->vm.clear_range = nop_clear_range;
ggtt->vm.insert_page = mock_insert_page;
ggtt->vm.insert_entries = mock_insert_entries;
ggtt->vm.cleanup = mock_cleanup;
--
2.34.1
next prev parent reply other threads:[~2023-03-08 15:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 15:39 [PATCH v5 0/4] drm/i915: add guard page to ggtt->error_capture Andrzej Hajda
2023-03-08 15:39 ` [PATCH v5 1/4] drm/i915/gt: make nop_clear_range public Andrzej Hajda
2023-03-09 0:00 ` Andi Shyti
2023-03-08 15:39 ` [PATCH v5 2/4] drm/i915/display: use nop_clear_range instead of local function Andrzej Hajda
2023-03-09 0:01 ` Andi Shyti
2023-03-08 15:39 ` Andrzej Hajda [this message]
2023-03-09 0:02 ` [PATCH v5 3/4] drm/i915/selftests: " Andi Shyti
2023-03-08 15:39 ` [PATCH v5 4/4] drm/i915: add guard page to ggtt->error_capture Andrzej Hajda
2023-03-09 9:08 ` Tvrtko Ursulin
2023-03-09 9:34 ` Andrzej Hajda
2023-03-09 9:43 ` Tvrtko Ursulin
2023-03-09 9:59 ` Andrzej Hajda
2023-03-09 10:17 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230308-guard_error_capture-v5-3-6d1410d13540@intel.com \
--to=andrzej.hajda@intel.com \
--cc=andi.shyti@linux.intel.com \
--cc=chris.p.wilson@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nirmoy.das@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®