From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Petr Malat <oss@malat.biz>
Cc: linux-kernel@vger.kernel.org, paulmck@kernel.org,
tglx@linutronix.de, nsaenzju@redhat.com, frederic@kernel.org
Subject: Re: [PATCH] softirq: Do not loop if running under a real-time task
Date: Wed, 8 Mar 2023 10:14:58 +0100 [thread overview]
Message-ID: <20230308091458.Q42uCjR2@linutronix.de> (raw)
In-Reply-To: <20230306154548.655799-1-oss@malat.biz>
On 2023-03-06 16:45:48 [+0100], Petr Malat wrote:
> Softirq processing can be a source of a scheduling jitter if it executes
> in a real-time task as in that case need_resched() is false unless there
> is another runnable task with a higher priority. This is especially bad
> if the softirq processing runs in a migration thread, which has priority
> 99 and usually runs for a short time.
>
> One option would be to not restart the softirq processing if there is
> another runnable task to allow the high prio task to finish and yield the
> CPU, the second one is to not restart if softirq executes in a real-time
> task. Usually, real-time tasks don't want to be interrupted, so implement
> the second option.
This affects only PEEMPT_RT, right?
I have plans to redo parts of it. You shouldn't enter ksoftirqd to be
begin with. There is this ktimerd in v6.1 which mitigates this to some
point and I plan to extend it to also cover the sched-softirq.
Other than that, you are right in saying that the softirq must not
continue with a RT prio and that need_resched() is not visible here.
However ksoftirqd itself must be able to do loops unless the
need-resched flag is seen.
Since you mentioned migration thread, how ofter to you see this or how
does this trigger?
> Signed-off-by: Petr Malat <oss@malat.biz>
Sebastian
next prev parent reply other threads:[~2023-03-08 9:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 15:45 Petr Malat
2023-03-08 9:14 ` Sebastian Andrzej Siewior [this message]
2023-03-09 13:03 ` Petr Malat
2024-07-25 8:44 ` Petr Malat
2024-08-07 15:32 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230308091458.Q42uCjR2@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nsaenzju@redhat.com \
--cc=oss@malat.biz \
--cc=paulmck@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®