mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	<linux-kernel@vger.kernel.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Michael Walle" <michael@walle.cc>,
	"Rafał Miłecki" <rafal@milecki.pl>,
	"Robert Marko" <robert.marko@sartura.hr>,
	"Luka Perkov" <luka.perkov@sartura.hr>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Frank Rowand" <frowand.list@gmail.com>,
	devicetree@vger.kernel.org,
	"Miquel Raynal" <miquel.raynal@bootlin.com>
Subject: [PATCH v3 12/20] nvmem: core: add per-cell post processing
Date: Wed,  8 Mar 2023 16:31:52 +0100	[thread overview]
Message-ID: <20230308153200.682248-13-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20230308153200.682248-1-miquel.raynal@bootlin.com>

From: Michael Walle <michael@walle.cc>

Instead of relying on the name the consumer is using for the cell, like
it is done for the nvmem .cell_post_process configuration parameter,
provide a per-cell post processing hook. This can then be populated by
the NVMEM provider (or the NVMEM layout) when adding the cell.

Signed-off-by: Michael Walle <michael@walle.cc>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 drivers/nvmem/core.c           | 17 +++++++++++++++++
 include/linux/nvmem-provider.h |  3 +++
 2 files changed, 20 insertions(+)

diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index 49b4bbaf59e8..0708f9f27898 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -54,6 +54,7 @@ struct nvmem_cell_entry {
 	int			bytes;
 	int			bit_offset;
 	int			nbits;
+	nvmem_cell_post_process_t read_post_process;
 	struct device_node	*np;
 	struct nvmem_device	*nvmem;
 	struct list_head	node;
@@ -470,6 +471,7 @@ static int nvmem_cell_info_to_nvmem_cell_entry_nodup(struct nvmem_device *nvmem,
 	cell->offset = info->offset;
 	cell->bytes = info->bytes;
 	cell->name = info->name;
+	cell->read_post_process = info->read_post_process;
 
 	cell->bit_offset = info->bit_offset;
 	cell->nbits = info->nbits;
@@ -1563,6 +1565,13 @@ static int __nvmem_cell_read(struct nvmem_device *nvmem,
 	if (cell->bit_offset || cell->nbits)
 		nvmem_shift_read_buffer_in_place(cell, buf);
 
+	if (cell->read_post_process) {
+		rc = cell->read_post_process(nvmem->priv, id, index,
+					     cell->offset, buf, cell->bytes);
+		if (rc)
+			return rc;
+	}
+
 	if (nvmem->cell_post_process) {
 		rc = nvmem->cell_post_process(nvmem->priv, id, index,
 					      cell->offset, buf, cell->bytes);
@@ -1671,6 +1680,14 @@ static int __nvmem_cell_entry_write(struct nvmem_cell_entry *cell, void *buf, si
 	    (cell->bit_offset == 0 && len != cell->bytes))
 		return -EINVAL;
 
+	/*
+	 * Any cells which have a read_post_process hook are read-only because
+	 * we cannot reverse the operation and it might affect other cells,
+	 * too.
+	 */
+	if (cell->read_post_process)
+		return -EINVAL;
+
 	if (cell->bit_offset || cell->nbits) {
 		buf = nvmem_cell_prepare_write_buffer(cell, buf, len);
 		if (IS_ERR(buf))
diff --git a/include/linux/nvmem-provider.h b/include/linux/nvmem-provider.h
index 535c5f9f3309..3bfc23553a9e 100644
--- a/include/linux/nvmem-provider.h
+++ b/include/linux/nvmem-provider.h
@@ -54,6 +54,8 @@ struct nvmem_keepout {
  * @bit_offset:	Bit offset if cell is smaller than a byte.
  * @nbits:	Number of bits.
  * @np:		Optional device_node pointer.
+ * @read_post_process:	Callback for optional post processing of cell data
+ *			on reads.
  */
 struct nvmem_cell_info {
 	const char		*name;
@@ -62,6 +64,7 @@ struct nvmem_cell_info {
 	unsigned int		bit_offset;
 	unsigned int		nbits;
 	struct device_node	*np;
+	nvmem_cell_post_process_t read_post_process;
 };
 
 /**
-- 
2.34.1


  parent reply	other threads:[~2023-03-08 15:33 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-08 15:31 [PATCH v3 00/20] [PATCH v3 00/20] nvmem: Layouts support Miquel Raynal
2023-03-08 15:31 ` [PATCH v3 01/20] of: Fix modalias string generation Miquel Raynal
2023-03-08 15:31 ` [PATCH v3 02/20] of: Update of_device_get_modalias() Miquel Raynal
2023-03-08 15:31 ` [PATCH v3 03/20] of: Rename of_modalias_node() Miquel Raynal
2023-03-08 15:38   ` Mark Brown
2023-03-08 15:31 ` [PATCH v3 04/20] of: Move of_modalias() to module.c Miquel Raynal
2023-03-09  2:22   ` Rob Herring
2023-03-08 15:31 ` [PATCH v3 05/20] of: Move the request module helper logic " Miquel Raynal
2023-03-08 15:31 ` [PATCH v3 06/20] usb: ulpi: Use of_request_module() Miquel Raynal
2023-03-08 15:50   ` Heikki Krogerus
2023-03-08 15:31 ` [PATCH v3 07/20] of: device: Kill of_device_request_module() Miquel Raynal
2023-03-08 15:31 ` [PATCH v3 08/20] dt-bindings: nvmem: Fix spelling mistake "platforn" -> "platform" Miquel Raynal
2023-03-08 15:31 ` [PATCH v3 09/20] nvmem: core: introduce NVMEM layouts Miquel Raynal
2023-03-10 10:55   ` Srinivas Kandagatla
2023-03-10 11:00     ` Rafał Miłecki
2023-03-08 15:31 ` [PATCH v3 10/20] nvmem: core: handle the absence of expected layouts Miquel Raynal
2023-03-08 15:31 ` [PATCH v3 11/20] nvmem: core: request layout modules loading Miquel Raynal
2023-03-08 15:31 ` Miquel Raynal [this message]
2023-03-08 15:31 ` [PATCH v3 13/20] nvmem: core: allow to modify a cell before adding it Miquel Raynal
2023-03-08 15:31 ` [PATCH v3 14/20] nvmem: imx-ocotp: replace global post processing with layouts Miquel Raynal
2023-03-08 15:31 ` [PATCH v3 15/20] nvmem: cell: drop global cell_post_process Miquel Raynal
2023-03-08 15:31 ` [PATCH v3 16/20] nvmem: core: provide own priv pointer in post process callback Miquel Raynal
2023-03-08 15:31 ` [PATCH v3 17/20] nvmem: layouts: sl28vpd: Add new layout driver Miquel Raynal
2023-03-10 11:03   ` Srinivas Kandagatla
2023-03-10 11:16     ` Miquel Raynal
2023-03-10 11:43       ` Srinivas Kandagatla
2023-03-08 15:31 ` [PATCH v3 18/20] MAINTAINERS: add myself as sl28vpd nvmem " Miquel Raynal
2023-03-08 15:31 ` [PATCH v3 19/20] nvmem: layouts: onie-tlv: Add new " Miquel Raynal
2023-03-08 15:32 ` [PATCH v3 20/20] MAINTAINERS: Add myself as ONIE tlv NVMEM layout maintainer Miquel Raynal
2023-03-14 11:28 ` [PATCH v3 00/20] [PATCH v3 00/20] nvmem: Layouts support Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230308153200.682248-13-miquel.raynal@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luka.perkov@sartura.hr \
    --cc=michael@walle.cc \
    --cc=rafal@milecki.pl \
    --cc=robert.marko@sartura.hr \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®