From: kernel test robot <lkp@intel.com>
To: Sam Protsenko <semen.protsenko@linaro.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Rob Herring <robh+dt@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev,
Alim Akhtar <alim.akhtar@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Chanho Park <chanho61.park@samsung.com>,
David Virag <virag.david003@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] soc: samsung: pm_domains: Implement proper I/O operations
Date: Thu, 9 Mar 2023 08:45:20 +0800 [thread overview]
Message-ID: <202303090824.TjEOnQJ8-lkp@intel.com> (raw)
In-Reply-To: <20230308230931.27261-5-semen.protsenko@linaro.org>
Hi Sam,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on krzk/for-next]
[also build test WARNING on robh/for-next krzk-dt/for-next linus/master v6.3-rc1 next-20230308]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Sam-Protsenko/dt-bindings-power-pd-samsung-Add-Exynos850-support/20230309-071202
base: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git for-next
patch link: https://lore.kernel.org/r/20230308230931.27261-5-semen.protsenko%40linaro.org
patch subject: [PATCH 4/6] soc: samsung: pm_domains: Implement proper I/O operations
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230309/202303090824.TjEOnQJ8-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/2dabd70f9264ef6cd044de6c3cbd3d83bfef8442
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Sam-Protsenko/dt-bindings-power-pd-samsung-Add-Exynos850-support/20230309-071202
git checkout 2dabd70f9264ef6cd044de6c3cbd3d83bfef8442
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/soc/samsung/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303090824.TjEOnQJ8-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/soc/samsung/pm_domains.c: In function 'exynos_pd_power':
>> drivers/soc/samsung/pm_domains.c:74:23: warning: variable 'base' set but not used [-Wunused-but-set-variable]
74 | void __iomem *base;
| ^~~~
vim +/base +74 drivers/soc/samsung/pm_domains.c
2dabd70f9264ef drivers/soc/samsung/pm_domains.c Sam Protsenko 2023-03-08 70
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 71 static int exynos_pd_power(struct generic_pm_domain *domain, bool power_on)
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 72 {
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 73 struct exynos_pm_domain *pd;
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 @74 void __iomem *base;
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 75 u32 timeout, pwr;
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 76 char *op;
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 77
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 78 pd = container_of(domain, struct exynos_pm_domain, pd);
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 79 base = pd->base;
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 80
c028e175713698 drivers/soc/samsung/pm_domains.c Krzysztof Kozlowski 2016-05-10 81 pwr = power_on ? pd->local_pwr_cfg : 0;
2dabd70f9264ef drivers/soc/samsung/pm_domains.c Sam Protsenko 2023-03-08 82 exynos_pd_write_conf(pd, pwr);
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 83
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 84 /* Wait max 1ms */
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 85 timeout = 10;
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 86
2dabd70f9264ef drivers/soc/samsung/pm_domains.c Sam Protsenko 2023-03-08 87 while (exynos_pd_read_status(pd) != pwr) {
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 88 if (!timeout) {
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 89 op = (power_on) ? "enable" : "disable";
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 90 pr_err("Power domain %s %s failed\n", domain->name, op);
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 91 return -ETIMEDOUT;
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 92 }
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 93 timeout--;
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 94 cpu_relax();
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 95 usleep_range(80, 100);
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 96 }
c760569d0e9c06 arch/arm/mach-exynos/pm_domains.c Prathyush K 2014-07-11 97
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 98 return 0;
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 99 }
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 100
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next prev parent reply other threads:[~2023-03-09 0:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230308230935eucas1p1e919f4d4b020e3386ce0eac8b4c8d299@eucas1p1.samsung.com>
2023-03-08 23:09 ` [PATCH 0/6] soc: samsung: pm_domains: Add Exynos850 support Sam Protsenko
2023-03-08 23:09 ` [PATCH 1/6] dt-bindings: power: pd-samsung: " Sam Protsenko
2023-03-09 9:15 ` Krzysztof Kozlowski
2023-03-08 23:09 ` [PATCH 2/6] dt-bindings: power: pd-samsung: Allow pd nodes to be children of PMU Sam Protsenko
2023-03-10 14:41 ` Krzysztof Kozlowski
2023-03-08 23:09 ` [PATCH 3/6] soc: samsung: pm_domains: Extract DT handling into a separate function Sam Protsenko
2023-03-08 23:09 ` [PATCH 4/6] soc: samsung: pm_domains: Implement proper I/O operations Sam Protsenko
2023-03-09 0:45 ` kernel test robot [this message]
2023-03-08 23:09 ` [PATCH 5/6] soc: samsung: pm_domains: Allow PD to be a child of PMU syscon Sam Protsenko
2023-03-08 23:09 ` [PATCH 6/6] soc: samsung: pm_domains: Add Exynos850 support Sam Protsenko
2023-03-09 10:12 ` [PATCH 0/6] " Marek Szyprowski
2023-03-10 14:41 ` Krzysztof Kozlowski
2023-03-20 17:57 ` Sam Protsenko
2023-03-22 18:52 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202303090824.TjEOnQJ8-lkp@intel.com \
--to=lkp@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=chanho61.park@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=robh+dt@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=virag.david003@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®