From: Eric Blake <eblake@redhat.com>
To: josef@toxicpanda.com, linux-block@vger.kernel.org, nbd@other.debian.org
Cc: philipp.reisner@linbit.com, lars.ellenberg@linbit.com,
christoph.boehmwalder@linbit.com, corbet@lwn.net,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] block nbd: use req.cookie instead of req.handle
Date: Fri, 10 Mar 2023 14:15:25 -0600 [thread overview]
Message-ID: <20230310201525.2615385-4-eblake@redhat.com> (raw)
In-Reply-To: <20230310201525.2615385-1-eblake@redhat.com>
A good compiler should not compile this any differently, but it seems
nicer to avoid memcpy() when integer assignment will work.
Signed-off-by: Eric Blake <eblake@redhat.com>
---
drivers/block/nbd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 592cfa8b765a..672fb8d1ce67 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -606,7 +606,7 @@ static int nbd_send_cmd(struct nbd_device *nbd, struct nbd_cmd *cmd, int index)
request.len = htonl(size);
}
handle = nbd_cmd_handle(cmd);
- memcpy(request.handle, &handle, sizeof(handle));
+ request.cookie = handle;
trace_nbd_send_request(&request, nbd->index, blk_mq_rq_from_pdu(cmd));
@@ -732,7 +732,7 @@ static struct nbd_cmd *nbd_handle_reply(struct nbd_device *nbd, int index,
u32 tag;
int ret = 0;
- memcpy(&handle, reply->handle, sizeof(handle));
+ handle = reply->cookie;
tag = nbd_handle_to_tag(handle);
hwq = blk_mq_unique_tag_to_hwq(tag);
if (hwq < nbd->tag_set.nr_hw_queues)
--
2.39.2
next prev parent reply other threads:[~2023-03-10 20:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 20:15 [PATCH 0/3] nbd: s/handle/cookie/ Eric Blake
2023-03-10 20:15 ` [PATCH 1/3] uapi nbd: improve doc links to userspace spec Eric Blake
2023-03-13 3:04 ` Ming Lei
2023-03-10 20:15 ` [PATCH 2/3] uapi nbd: add cookie alias to handle Eric Blake
2023-03-11 12:30 ` Nir Soffer
2023-03-14 19:50 ` Eric Blake
2023-03-15 3:33 ` Ming Lei
2023-03-10 20:15 ` Eric Blake [this message]
2023-03-11 12:22 ` [PATCH 3/3] block nbd: use req.cookie instead of req.handle Nir Soffer
2023-03-14 19:56 ` Eric Blake
2023-03-12 5:12 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230310201525.2615385-4-eblake@redhat.com \
--to=eblake@redhat.com \
--cc=christoph.boehmwalder@linbit.com \
--cc=corbet@lwn.net \
--cc=josef@toxicpanda.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nbd@other.debian.org \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®