From: Tom Rix <trix@redhat.com>
To: broonie@kernel.org
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Tom Rix <trix@redhat.com>
Subject: [PATCH] Revert "spi: fsi: Make available for build test"
Date: Fri, 10 Mar 2023 15:28:48 -0500 [thread overview]
Message-ID: <20230310202848.437655-1-trix@redhat.com> (raw)
This reverts commit f916c7080d28831493518364492e33fc6a437907.
A rand config causes this link error
drivers/spi/spi-fsi.o: In function `fsi_spi_probe':
spi-fsi.c:(.text+0x2c): undefined reference to `fsi_slave_read'
The rand config has
CONFIG_SPI_FSI=y
CONFIG_COMPILE_TEST=y
CONFIG_OF=n
CONFIG_FSI=n
Building fails unless FSI is enabled, so using || COMPILE_TEST is a mistake.
Fixes: f916c7080d28 ("spi: fsi: Make available for build test")
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/spi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 36a18c215163..80f3cade6006 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -357,7 +357,7 @@ config SPI_FALCON
config SPI_FSI
tristate "FSI SPI driver"
- depends on FSI || COMPILE_TEST
+ depends on FSI
help
This enables support for the driver for FSI bus attached SPI
controllers.
--
2.27.0
reply other threads:[~2023-03-10 20:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230310202848.437655-1-trix@redhat.com \
--to=trix@redhat.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®