From: Peter Zijlstra <peterz@infradead.org>
To: Josh Poimboeuf <jpoimboe@kernel.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
Jason Baron <jbaron@akamai.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ard Biesheuvel <ardb@kernel.org>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <seanjc@google.com>
Subject: Re: [RFC][PATCH 1/5] static_call: Make NULL static calls consistent
Date: Fri, 10 Mar 2023 21:59:26 +0100 [thread overview]
Message-ID: <20230310205926.GB1605437@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <016c1e9cbdf726a885a406ff6baed85087ad1213.1678474914.git.jpoimboe@kernel.org>
On Fri, Mar 10, 2023 at 12:31:13PM -0800, Josh Poimboeuf wrote:
> -/*
> - * This horrific hack takes care of two things:
> - *
> - * - it ensures the compiler will only load the function pointer ONCE,
> - * which avoids a reload race.
> - *
> - * - it ensures the argument evaluation is unconditional, similar
> - * to the HAVE_STATIC_CALL variant.
> - *
> - * Sadly current GCC/Clang (10 for both) do not optimize this properly
> - * and will emit an indirect call for the NULL case :-(
> - */
> -#define __static_call_cond(name) \
> -({ \
> - void *func = READ_ONCE(STATIC_CALL_KEY(name).func); \
> - if (!func) \
> - func = &__static_call_nop; \
> - (typeof(STATIC_CALL_TRAMP(name))*)func; \
> -})
So a sufficiently clever compiler can optimize the above to avoid the
actual indirect call (and resulting CFI violation, see below), because
__static_call_nop() is inline and hence visible as an empty stub
function. Currently none of the compilers are that clever :/
> -#define static_call_cond(name) (void)__static_call_cond(name)
> +#define static_call_cond(name) (void)static_call(name)
>
> static inline
> void __static_call_update(struct static_call_key *key, void *tramp, void *func)
> {
> - WRITE_ONCE(key->func, func);
> + WRITE_ONCE(key->func, func ? : (void *)__static_call_nop);
> }
This will break ARM64 I think, they don't HAVE_STATIC_CALL but do have
CLANG_CFI, which means the above will end up being a runtime indirect
call to a non-matching signature function.
Now, I suppose we don't actually have this happen in current code by the
simple expedient of not actually having any static_call_cond() usage
outside of arch code.
(/me git-grep's some and *arrrggh* trusted-keys)
I really don't think we can do this though, must not promote CFI
violations.
next prev parent reply other threads:[~2023-03-10 21:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 20:31 [RFC][PATCH 0/5] Improve static call NULL handling Josh Poimboeuf
2023-03-10 20:31 ` [RFC][PATCH 1/5] static_call: Make NULL static calls consistent Josh Poimboeuf
2023-03-10 20:59 ` Peter Zijlstra [this message]
2023-03-11 1:20 ` Josh Poimboeuf
2023-03-12 15:17 ` Peter Zijlstra
2023-03-13 15:08 ` Sean Christopherson
2023-03-13 17:48 ` Sami Tolvanen
2023-03-14 1:58 ` Josh Poimboeuf
2023-03-14 10:06 ` Peter Zijlstra
2023-03-10 20:31 ` [RFC][PATCH 2/5] static_call: Make NULL static calls return 0 Josh Poimboeuf
2023-03-10 20:31 ` [RFC][PATCH 3/5] static_call: Remove static_call_cond() and its usages Josh Poimboeuf
2023-03-10 20:31 ` [RFC][PATCH 4/5] static_call: Remove DEFINE_STATIC_CALL_RET0() and its uses Josh Poimboeuf
2023-03-10 20:31 ` [RFC][PATCH 5/5] x86/kvm: Simplify static call handling Josh Poimboeuf
2023-03-10 21:07 ` Sean Christopherson
2023-03-10 21:13 ` Steven Rostedt
2023-03-10 21:29 ` Sean Christopherson
2023-03-10 22:23 ` Josh Poimboeuf
2023-03-10 21:09 ` [RFC][PATCH 0/5] Improve static call NULL handling Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230310205926.GB1605437@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ardb@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=jbaron@akamai.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pbonzini@redhat.com \
--cc=rostedt@goodmis.org \
--cc=seanjc@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®