mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	"Thomas Weißschuh" <linux@weissschuh.net>,
	"Mirsad Todorovac" <mirsad.todorovac@alu.unizg.hr>
Subject: [PATCH 0/4] kobject: properly warn on missing release function
Date: Sat, 11 Mar 2023 03:14:45 +0000	[thread overview]
Message-ID: <20230311-kobject-warning-v1-0-1ebba4f71fb5@weissschuh.net> (raw)

This series contains:
* Patch 1 & 2: some cleanups for the logging in kobject.c
* Patch 3: Moves the validation of the release function from cleanup()
  to add() so the messages are not shown during shutdown where they are
  hard to see.
* Patch 4: Increases the logging level for the release function
  validation.

Please note that Patch 4 will trigger warnings on boot on at least all
machines with ACPI or block devices.
So this patch should probably not be applied yet.

The block dev part is being worked on here:
https://lore.kernel.org/lkml/20230309-kobj_release-gendisk_integrity-v2-0-761a50d71900@weissschuh.net/

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
Thomas Weißschuh (4):
      kobject: define common logging prefix
      kobject: align stacktrace levels to logging message
      kobject: validate ktype release function during add
      kobject: upgrade log of missing release func to warn

 lib/kobject.c | 42 +++++++++++++++++++++++-------------------
 1 file changed, 23 insertions(+), 19 deletions(-)
---
base-commit: 55a21105ecc156495446d8ae75d7d73f66baed7b
change-id: 20230311-kobject-warning-d87a2f7b5e66

Best regards,
-- 
Thomas Weißschuh <linux@weissschuh.net>


             reply	other threads:[~2023-03-11  3:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-11  3:14 Thomas Weißschuh [this message]
2023-03-11  3:14 ` [PATCH 1/4] kobject: define common logging prefix Thomas Weißschuh
2023-03-11  3:14 ` [PATCH 2/4] kobject: align stacktrace levels to logging message Thomas Weißschuh
2023-03-11  3:14 ` [PATCH 3/4] kobject: validate ktype release function during add Thomas Weißschuh
2023-03-11  8:10   ` Greg Kroah-Hartman
2023-03-11  3:14 ` [PATCH 4/4] kobject: upgrade log of missing release func to warn Thomas Weißschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230311-kobject-warning-v1-0-1ebba4f71fb5@weissschuh.net \
    --to=linux@weissschuh.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mirsad.todorovac@alu.unizg.hr \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®