From: Christian Brauner <brauner@kernel.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHES] fget()-to-fdget() whack-a-mole
Date: Mon, 13 Mar 2023 12:52:05 +0100 [thread overview]
Message-ID: <20230313115205.mw2dud27lcjszqij@wittgenstein> (raw)
In-Reply-To: <20230310212536.GX3390869@ZenIV>
On Fri, Mar 10, 2023 at 09:25:36PM +0000, Al Viro wrote:
> fget()/fget_raw() should be used when we are going to keep
> struct file reference; for temporary references fdget()/fdget_raw()
> ought to be used. That kind of stuff keeps cropping up on a regular
Fwiw, might be worth to mention/document that explicitly anywhere.
I didn't see anything but might've missed it.
> basis, and it needs periodic pruning.
>
> The current pile is in vfs.git #work.fd; individual patches
> in followups.
Reviewed-by: Christian Brauner <brauner@kernel.org>
prev parent reply other threads:[~2023-03-13 11:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 21:25 Al Viro
2023-03-10 21:27 ` [PATCH 1/8] convert setns(2) to fdget()/fdput() Al Viro
2023-03-10 21:27 ` [PATCH 2/8] convert sgx_set_attribute() " Al Viro
2023-03-10 21:27 ` [PATCH 3/8] SVM-SEV: convert the rest of fget() uses to fdget() in there Al Viro
2023-03-10 21:27 ` [PATCH 4/8] kill the last remaining user of proc_ns_fget() Al Viro
2023-03-10 21:27 ` [PATCH 5/8] build_mount_idmapped(): switch to fdget() Al Viro
2023-03-10 21:27 ` [PATCH 6/8] bpf: switch to fdget_raw() Al Viro
2023-03-10 21:27 ` [PATCH 7/8] cgroup_get_from_fd(): " Al Viro
2023-03-10 21:27 ` [PATCH 8/8] fuse_dev_ioctl(): switch to fdget() Al Viro
2023-03-13 11:52 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230313115205.mw2dud27lcjszqij@wittgenstein \
--to=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®