From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, rafael@kernel.org, jikos@kernel.org
Subject: Re: [PATCH 04/12] driver core: class: remove module * from class_create()
Date: Wed, 15 Mar 2023 09:34:07 +0100 [thread overview]
Message-ID: <20230315083407.pkcqq3igjszuz7ms@mail.corp.redhat.com> (raw)
In-Reply-To: <20230313181843.1207845-4-gregkh@linuxfoundation.org>
On Mar 13 2023, Greg Kroah-Hartman wrote:
> The module pointer in class_create() never actually did anything, and it
> shouldn't have been requred to be set as a parameter even if it did
> something. So just remove it and fix up all callers of the function in
> the kernel tree at the same time.
>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> arch/mips/kernel/mips-mt.c | 2 +-
> arch/mips/sibyte/common/sb_tbprof.c | 2 +-
> arch/powerpc/platforms/book3s/vas-api.c | 2 +-
> arch/x86/kernel/cpu/resctrl/pseudo_lock.c | 2 +-
> arch/x86/kernel/cpuid.c | 2 +-
> arch/x86/kernel/msr.c | 2 +-
> block/bsg.c | 2 +-
> drivers/accel/drm_accel.c | 2 +-
> drivers/accel/habanalabs/common/habanalabs_drv.c | 2 +-
> drivers/base/power/wakeup_stats.c | 2 +-
> drivers/block/aoe/aoechr.c | 2 +-
> drivers/block/rnbd/rnbd-clt-sysfs.c | 2 +-
> drivers/block/rnbd/rnbd-srv-sysfs.c | 2 +-
> drivers/block/ublk_drv.c | 2 +-
> drivers/char/bsr.c | 2 +-
> drivers/char/dsp56k.c | 2 +-
> drivers/char/ipmi/ipmi_devintf.c | 2 +-
> drivers/char/lp.c | 2 +-
> drivers/char/mem.c | 2 +-
> drivers/char/misc.c | 2 +-
> drivers/char/pcmcia/cm4000_cs.c | 2 +-
> drivers/char/pcmcia/cm4040_cs.c | 2 +-
> drivers/char/pcmcia/scr24x_cs.c | 2 +-
> drivers/char/ppdev.c | 2 +-
> drivers/char/tpm/tpm-interface.c | 4 ++--
> drivers/char/virtio_console.c | 2 +-
> drivers/char/xilinx_hwicap/xilinx_hwicap.c | 2 +-
> drivers/char/xillybus/xillybus_class.c | 2 +-
> drivers/comedi/comedi_fops.c | 2 +-
> drivers/comedi/drivers/comedi_test.c | 2 +-
> drivers/crypto/qat/qat_common/adf_ctl_drv.c | 2 +-
> drivers/dca/dca-sysfs.c | 2 +-
> drivers/devfreq/devfreq-event.c | 2 +-
> drivers/devfreq/devfreq.c | 2 +-
> drivers/dma-buf/dma-heap.c | 2 +-
> drivers/extcon/extcon.c | 2 +-
> drivers/fpga/fpga-bridge.c | 2 +-
> drivers/fpga/fpga-mgr.c | 2 +-
> drivers/fpga/fpga-region.c | 2 +-
> drivers/gnss/core.c | 2 +-
> drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +-
> drivers/gpu/drm/display/drm_dp_aux_dev.c | 2 +-
> drivers/gpu/drm/drm_sysfs.c | 2 +-
> drivers/hid/hid-roccat-arvo.c | 2 +-
> drivers/hid/hid-roccat-isku.c | 2 +-
> drivers/hid/hid-roccat-kone.c | 2 +-
> drivers/hid/hid-roccat-koneplus.c | 2 +-
> drivers/hid/hid-roccat-konepure.c | 2 +-
> drivers/hid/hid-roccat-kovaplus.c | 2 +-
> drivers/hid/hid-roccat-pyra.c | 2 +-
> drivers/hid/hid-roccat-ryos.c | 2 +-
> drivers/hid/hid-roccat-savu.c | 2 +-
> drivers/hid/hidraw.c | 2 +-
For the HID part:
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
[...]
next prev parent reply other threads:[~2023-03-15 8:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 18:18 [PATCH 01/12] driver core: class: specify the module owner in __class_register() Greg Kroah-Hartman
2023-03-13 18:18 ` [PATCH 02/12] drivers: remove struct module * setting from struct class Greg Kroah-Hartman
2023-03-13 18:18 ` [PATCH 03/12] driver core: class: remove struct module owner out of " Greg Kroah-Hartman
2023-03-13 18:18 ` [PATCH 04/12] driver core: class: remove module * from class_create() Greg Kroah-Hartman
2023-03-15 8:34 ` Benjamin Tissoires [this message]
2023-03-13 18:18 ` [PATCH 05/12] driver core: class: make class_dev_iter_init() options const Greg Kroah-Hartman
2023-03-13 18:18 ` [PATCH 06/12] driver core: class: make class_for_each_device() " Greg Kroah-Hartman
2023-03-13 18:18 ` [PATCH 07/12] driver core: class: make class_find_device*() " Greg Kroah-Hartman
2023-03-13 18:18 ` [PATCH 08/12] driver core: class: make class_create/remove_file*() " Greg Kroah-Hartman
2023-03-13 18:18 ` [PATCH 09/12] driver core: device: make device_destroy() take a const class * Greg Kroah-Hartman
2023-03-13 18:18 ` [PATCH 10/12] tpm: fix up the tpm_class shutdown_pre pointer when created Greg Kroah-Hartman
2023-03-14 11:09 ` Jarkko Sakkinen
2023-03-14 12:53 ` Greg Kroah-Hartman
2023-03-14 12:57 ` Jarkko Sakkinen
2023-03-13 18:18 ` [PATCH 11/12] driver core: device: mark struct class in struct device as constant Greg Kroah-Hartman
2023-03-13 18:18 ` [PATCH 12/12] driver core: device: make device_create*() take a const struct class * Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230315083407.pkcqq3igjszuz7ms@mail.corp.redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®