From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A324C7618A for ; Wed, 15 Mar 2023 11:20:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231503AbjCOLUw (ORCPT ); Wed, 15 Mar 2023 07:20:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231488AbjCOLU3 (ORCPT ); Wed, 15 Mar 2023 07:20:29 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B851DBDF; Wed, 15 Mar 2023 04:19:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Y1qbaNmKGtblNVhdlxDCOnZuD6KOCPFbJF9ZFx/bdFM=; b=r9sY4aY3ZXCD0AcKFsKkZA5YuC aIpytDEDMlZWSG0ayXCImdw3to0/+P8A12SOeeirCAWSzGf4HoEL6a09f8wVRmKh4wIgf4S+j0poD aQa+zFKzEVKRJ+mrYP1x/RwdKl4Rdr6wUyavTo74ONgR2GLhGhS+ZtT8zV89SgDXvAcO8CEgHm3h7 jsdSYpqFO5InR0xfLRpm8f8ksdxjAIGDqyQWBeIYkcgthiKUFDuAj9J8FT6qgKVMsxbnxXPDKZTrh IukN0ALe+uTYJT1fNTtje36S90BSYB6W7ATPK2uFsbyOuuKYS08IIXDKTaXM9jqNr7rENnFOBDIbN GCNVi9cg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pcPAV-00Dmgc-Hw; Wed, 15 Mar 2023 11:19:44 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id F2FFB300288; Wed, 15 Mar 2023 12:19:41 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id DAF6920FF20AE; Wed, 15 Mar 2023 12:19:41 +0100 (CET) Date: Wed, 15 Mar 2023 12:19:41 +0100 From: Peter Zijlstra To: Mike Rapoport Cc: "Matthew Wilcox (Oracle)" , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Subject: Re: [PATCH v4 27/36] x86: Implement the new page table range API Message-ID: <20230315111941.GC2006103@hirez.programming.kicks-ass.net> References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-28-willy@infradead.org> <20230315103436.GA2006103@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 15, 2023 at 01:16:24PM +0200, Mike Rapoport wrote: > On Wed, Mar 15, 2023 at 11:34:36AM +0100, Peter Zijlstra wrote: > > On Wed, Mar 15, 2023 at 05:14:35AM +0000, Matthew Wilcox (Oracle) wrote: > > > Add PFN_PTE_SHIFT and a noop update_mmu_cache_range(). > > > > > > Signed-off-by: Matthew Wilcox (Oracle) > > > Cc: Thomas Gleixner > > > Cc: Ingo Molnar > > > Cc: Borislav Petkov > > > Cc: Dave Hansen > > > Cc: x86@kernel.org > > > Cc: "H. Peter Anvin" > > > --- > > > arch/x86/include/asm/pgtable.h | 13 ++++++------- > > > 1 file changed, 6 insertions(+), 7 deletions(-) > > > > > > diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h > > > index 1031025730d0..b237878061c4 100644 > > > --- a/arch/x86/include/asm/pgtable.h > > > +++ b/arch/x86/include/asm/pgtable.h > > > @@ -184,6 +184,8 @@ static inline int pte_special(pte_t pte) > > > > > > static inline u64 protnone_mask(u64 val); > > > > > > +#define PFN_PTE_SHIFT PAGE_SHIFT > > > + > > > static inline unsigned long pte_pfn(pte_t pte) > > > { > > > phys_addr_t pfn = pte_val(pte); > > > @@ -1019,13 +1021,6 @@ static inline pud_t native_local_pudp_get_and_clear(pud_t *pudp) > > > return res; > > > } > > > > > > -static inline void set_pte_at(struct mm_struct *mm, unsigned long addr, > > > - pte_t *ptep, pte_t pte) > > > -{ > > > - page_table_check_ptes_set(mm, addr, ptep, pte, 1); > > > - set_pte(ptep, pte); > > > -} > > > - > > > > And remove set_pte_at() apparently.. whut?!? > > It's now in include/linux/pgtable.h All I have is this one patch -- and the changelog doesn't mention this. HTF am I supposed to know that?