From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 578C6C6FD1D for ; Fri, 17 Mar 2023 23:59:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229823AbjCQX7M (ORCPT ); Fri, 17 Mar 2023 19:59:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229516AbjCQX7J (ORCPT ); Fri, 17 Mar 2023 19:59:09 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 600AC77991 for ; Fri, 17 Mar 2023 16:59:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3878C60B81 for ; Fri, 17 Mar 2023 23:59:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C80CC433EF; Fri, 17 Mar 2023 23:59:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1679097546; bh=m6/a10CVnRU0DBLRiwVNu4MUaIUuwYZVNvRbzYhnpZ0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FPsyJDFfTSUm3O8MS0sgG6du4oIaoVMYwrm0+V4kBhyekibpHRlAqdpu4UwWDpRem rd81GwY4ueWVBlJSlfRVF9+2KwSLV4dey1jbIweDOU/Cu/G7Jk4rTWu7WaGVUcsi6j PdRV76yi8fdf1nDNmUs0PNfQKhi+qZn3kLwmqSqM= Date: Fri, 17 Mar 2023 16:59:05 -0700 From: Andrew Morton To: Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand , Matthew Wilcox , Vlastimil Babka Subject: Re: [PATCH 0/2] Refactor do_fault_around() Message-Id: <20230317165905.f4f90b125e459617fa19a3d5@linux-foundation.org> In-Reply-To: <98fc8545-6bd3-4c06-9b12-d781a19982ac@lucifer.local> References: <20230317163936.06d9c7d032a5c2296075caa1@linux-foundation.org> <98fc8545-6bd3-4c06-9b12-d781a19982ac@lucifer.local> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 17 Mar 2023 23:48:17 +0000 Lorenzo Stoakes wrote: > I went so far as to literally copy/paste > the existing code and my speculative change to a userland program, generate a > whole host of random sensible input data and compare output data with this and > the original logic en masse. Ah, great, all good, thanks.