From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15E85C6FD1F for ; Mon, 20 Mar 2023 01:01:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231217AbjCTBBt (ORCPT ); Sun, 19 Mar 2023 21:01:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231317AbjCTBA0 (ORCPT ); Sun, 19 Mar 2023 21:00:26 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BEC3113E4; Sun, 19 Mar 2023 17:56:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CD6DEB80D58; Mon, 20 Mar 2023 00:56:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A139C4339C; Mon, 20 Mar 2023 00:56:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679273800; bh=JdwcpTaCPqGYqH8ZNW3V9wksl+MihmMVFGj0G9nc/R0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T9QlMp5U/0RQsBWdbcqfrOrGsJUuN1+XsDH9DG3JxVPH9U7Cd1+aKp+NRIIej4aI+ MW+jmUyndrmUwYSP5Yqri9pelagaHbRhX40DTuWirfo0uk5EhBrEBjXOPnQ2rxBBkj CuXyJKDV1vbjBwgWImhB3fx+gI6Wt0qWFRqwH1eZmp+qQvxvZxL4DKnOSgGcbR0zBG EC0YCYJIMPMnsBWJ2hnXJdyKzUGAlNpFUZUB2BmhMEnfxoCe2dXQ+yi3NXEYSbS735 +IrxSgCXJc5Zbg26GvRzDPzezN1aCxHbaHgad2dfsbCAk0rQkiMGYROSj6tBzFnlF0 WY69Ak4ICoVhQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alexander Aring , lianhui tang , Stefan Schmidt , Sasha Levin , alex.aring@gmail.com, miquel.raynal@bootlin.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-wpan@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 02/12] ca8210: fix mac_len negative array access Date: Sun, 19 Mar 2023 20:56:25 -0400 Message-Id: <20230320005636.1429242-2-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230320005636.1429242-1-sashal@kernel.org> References: <20230320005636.1429242-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexander Aring [ Upstream commit 6c993779ea1d0cccdb3a5d7d45446dd229e610a3 ] This patch fixes a buffer overflow access of skb->data if ieee802154_hdr_peek_addrs() fails. Reported-by: lianhui tang Signed-off-by: Alexander Aring Link: https://lore.kernel.org/r/20230217042504.3303396-1-aahringo@redhat.com Signed-off-by: Stefan Schmidt Signed-off-by: Sasha Levin --- drivers/net/ieee802154/ca8210.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c index 66cf09e637e4e..498a82ab4eaf4 100644 --- a/drivers/net/ieee802154/ca8210.c +++ b/drivers/net/ieee802154/ca8210.c @@ -1955,6 +1955,8 @@ static int ca8210_skb_tx( * packet */ mac_len = ieee802154_hdr_peek_addrs(skb, &header); + if (mac_len < 0) + return mac_len; secspec.security_level = header.sec.level; secspec.key_id_mode = header.sec.key_id_mode; -- 2.39.2