From: Yangtao Li <frank.li@vivo.com>
To: jack@suse.cz
Cc: frank.li@vivo.com, jack@suse.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] quota: check for register_sysctl() failure
Date: Mon, 20 Mar 2023 19:40:28 +0800 [thread overview]
Message-ID: <20230320114029.76809-1-frank.li@vivo.com> (raw)
In-Reply-To: <20230320111229.a2zi3m5rszuhffwx@quack3>
> Well, but this is going to make system unbootable with
> CONFIG_QUOTA && !CONFIG_SYSCTL.
> Quota functionality actually does not depend on sysctl being
> available so just continuing without sysctl is perfectly fine.
To be honest, I'm a little confused. Should we panic if quota
registration fails, or should it depend on the user's cmdline
parameters? Just like in the filesystem where we can choose
whether to panic in case of exceptions.
Or, should we panic if registration fails when
CONFIG_QUOTA && CONFIG_SYSCTL are enabled?
BTW, kindly ping for:
https://lore.kernel.org/lkml/20230228103515.sb6qpvnmbvenvq73@quack3/
Not sure if you have forgotten to pick these two commits.
Thx,
Yangtao
next prev parent reply other threads:[~2023-03-20 11:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-18 16:06 Yangtao Li
2023-03-20 11:12 ` Jan Kara
2023-03-20 11:40 ` Yangtao Li [this message]
2023-03-20 17:11 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230320114029.76809-1-frank.li@vivo.com \
--to=frank.li@vivo.com \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®