mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Florent Revest <revest@chromium.org>
Cc: Jiri Olsa <olsajiri@gmail.com>,
	linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	mhiramat@kernel.org, mark.rutland@arm.com, ast@kernel.org,
	daniel@iogearbox.net, kpsingh@kernel.org
Subject: Re: [PATCH 5/7] ftrace: Store direct called addresses in their ops
Date: Mon, 20 Mar 2023 17:31:55 -0400	[thread overview]
Message-ID: <20230320173155.55f38adc@gandalf.local.home> (raw)
In-Reply-To: <CABRcYmL_JCAGSoX98dZUhGkmek+5iL4kd+F_POJ65GfnZLADcg@mail.gmail.com>

On Mon, 20 Mar 2023 18:45:08 +0100
Florent Revest <revest@chromium.org> wrote:

> On Sun, Mar 19, 2023 at 7:55 PM Jiri Olsa <olsajiri@gmail.com> wrote:
> >
> > On Sun, Mar 19, 2023 at 01:54:43PM -0400, Steven Rostedt wrote:  
> > > On Sun, 19 Mar 2023 16:29:22 +0100
> > > Jiri Olsa <olsajiri@gmail.com> wrote:
> > >  
> > > > > +++ b/kernel/trace/ftrace.c
> > > > > @@ -2582,9 +2582,8 @@ ftrace_add_rec_direct(unsigned long ip, unsigned long addr,
> > > > >  static void call_direct_funcs(unsigned long ip, unsigned long pip,
> > > > >                         struct ftrace_ops *ops, struct ftrace_regs *fregs)
> > > > >  {
> > > > > - unsigned long addr;
> > > > > + unsigned long addr = ops->direct_call;  
> > > >
> > > > nice, should it be read with READ_ONCE ?  
> > >
> > > Is there a "read tearing" too?  
> >
> > don't know, saw the comment in __modify_ftrace_direct and got curious
> > why it's not in here.. feel free to ignore, I'll look it up
> >
> > jirka  
> 
> Mhh, that's a good question. Based on my current understanding, it
> seems that it should have a READ_ONCE, indeed. However, I'd like Mark
> to confirm/deny this. :)
> 
> If this should be a READ_ONCE, I can send a v2 series with this fixed.

After re-reading: https://lwn.net/Articles/793253/

I think we should add the READ_ONCE() (also with a comment).

-- Steve

  reply	other threads:[~2023-03-20 21:33 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-16 17:38 [PATCH 0/7] Refactor ftrace direct call APIs Florent Revest
2023-03-16 17:38 ` [PATCH 1/7] ftrace: Let unregister_ftrace_direct_multi() call ftrace_free_filter() Florent Revest
2023-03-21  9:47   ` Mark Rutland
2023-03-21 10:40     ` Jiri Olsa
2023-03-16 17:38 ` [PATCH 2/7] ftrace: Replace uses of _ftrace_direct APIs with _ftrace_direct_multi Florent Revest
2023-03-16 17:38 ` [PATCH 3/7] ftrace: Remove the legacy _ftrace_direct API Florent Revest
2023-03-16 17:38 ` [PATCH 4/7] ftrace: Rename _ftrace_direct_multi APIs to _ftrace_direct APIs Florent Revest
2023-03-19 15:29   ` Jiri Olsa
2023-03-19 17:55     ` Steven Rostedt
2023-03-19 18:22       ` Jiri Olsa
2023-03-20  0:47         ` Steven Rostedt
2023-03-20  8:05           ` Jiri Olsa
2023-03-20 17:41             ` Florent Revest
2023-03-16 17:38 ` [PATCH 5/7] ftrace: Store direct called addresses in their ops Florent Revest
2023-03-19 15:29   ` Jiri Olsa
2023-03-19 17:54     ` Steven Rostedt
2023-03-19 18:54       ` Jiri Olsa
2023-03-20 17:45         ` Florent Revest
2023-03-20 21:31           ` Steven Rostedt [this message]
2023-03-21 10:20             ` Mark Rutland
2023-03-16 17:38 ` [PATCH 6/7] ftrace: Make DIRECT_CALLS work WITH_ARGS and !WITH_REGS Florent Revest
2023-03-16 17:38 ` [PATCH 7/7] ftrace: selftest: remove broken trace_direct_tramp Florent Revest

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230320173155.55f38adc@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=ast@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kpsingh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mhiramat@kernel.org \
    --cc=olsajiri@gmail.com \
    --cc=revest@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®