From: Aleksa Sarai <cyphar@cyphar.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Pedro Falcato <pedro.falcato@gmail.com>,
Christian Brauner <brauner@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] do_open(): Fix O_DIRECTORY | O_CREAT behavior
Date: Tue, 21 Mar 2023 09:10:28 +1100 [thread overview]
Message-ID: <20230320221028.srckvaqtsbmnwczh@senku> (raw)
In-Reply-To: <CAHk-=wgc9qYOtuyW_Tik0AqMrQJK00n-LKWvcBifLyNFUdohDw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 539 bytes --]
On 2023-03-20, Linus Torvalds <torvalds@linux-foundation.org> wrote:
> What about O_PATH? I guess it's fine to create a file and only get a
> path fd to the result?
O_PATH ignores the O_CREAT flag so it's the same as just passing O_PATH.
This is the case for all flags not in O_PATH_FLAGS (so only O_DIRECTORY,
O_NOFOLLOW, O_CLOEXEC have an effect on O_PATH). With openat2, passing
any other flag with O_PATH returns -EINVAL.
--
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-03-20 22:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 7:14 Pedro Falcato
2023-03-20 11:51 ` Christian Brauner
2023-03-20 17:14 ` Linus Torvalds
2023-03-20 19:27 ` Pedro Falcato
2023-03-20 20:24 ` Linus Torvalds
2023-03-20 22:10 ` Aleksa Sarai [this message]
2023-03-21 14:24 ` Christian Brauner
2023-03-21 16:17 ` Christian Brauner
2023-03-21 17:35 ` Linus Torvalds
2023-03-21 20:16 ` Christian Brauner
2023-03-21 21:47 ` Linus Torvalds
2023-03-22 10:17 ` Christian Brauner
2023-03-22 17:07 ` Linus Torvalds
2023-03-27 20:13 ` Pedro Falcato
2023-03-28 8:12 ` Christian Brauner
2023-03-28 2:15 ` Josh Triplett
2023-03-28 3:32 ` Linus Torvalds
2023-03-28 4:00 ` Josh Triplett
2023-03-28 7:57 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230320221028.srckvaqtsbmnwczh@senku \
--to=cyphar@cyphar.com \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pedro.falcato@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®