From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EEA0C6FD1F for ; Wed, 22 Mar 2023 20:03:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231583AbjCVUDL (ORCPT ); Wed, 22 Mar 2023 16:03:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230503AbjCVUC2 (ORCPT ); Wed, 22 Mar 2023 16:02:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50E986C18D; Wed, 22 Mar 2023 12:59:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A4EF4622B0; Wed, 22 Mar 2023 19:58:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 145C8C4339B; Wed, 22 Mar 2023 19:58:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679515134; bh=owSwlma77mkOCIyn2UW6eaOPLBHPastApHjuYD7u7cI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U25O5FlT+olGyIIi1H4dNik5NUFnM6QoNUJJqK5DaQNeLpfLFAtJ+aRFZTheIzl7c mFZ+xoxFHaBYImoR0MQdPn9U/NA4H5zwEFz9ShaSPjUfgeGCf377mcFkb2mLGSwjYR Oj7l0yrooJVKchIwxb1SB70yPcNJGAZn+FaMyJT/rAzknvPzCtJZCuI3mOwNV5RLXJ PY7SHZ5/tCACeysrK9afXK8Nb8+kvHMe+gzWPvGBjYgux7bJWFhwyOW11eFeW2oNnk 2/d4i/l1q85Ieg4MArPFcFAVFnHS38/qLCf204Soof29X0Hk9CKQu8KfEzt4aop3mo vIKggsyZPAR5w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Kristian Overskeid , "David S . Miller" , Sasha Levin , edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, bigeasy@linutronix.de, kurt@linutronix.de, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 6.2 29/45] net: hsr: Don't log netdev_err message on unknown prp dst node Date: Wed, 22 Mar 2023 15:56:23 -0400 Message-Id: <20230322195639.1995821-29-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230322195639.1995821-1-sashal@kernel.org> References: <20230322195639.1995821-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kristian Overskeid [ Upstream commit 28e8cabe80f3e6e3c98121576eda898eeb20f1b1 ] If no frames has been exchanged with a node for HSR_NODE_FORGET_TIME, the node will be deleted from the node_db list. If a frame is sent to the node after it is deleted, a netdev_err message for each slave interface is produced. This should not happen with dan nodes because of supervision frames, but can happen often with san nodes, which clutters the kernel log. Since the hsr protocol does not support sans, this is only relevant for the prp protocol. Signed-off-by: Kristian Overskeid Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/hsr/hsr_framereg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/hsr/hsr_framereg.c b/net/hsr/hsr_framereg.c index 00db74d96583d..865eda39d6014 100644 --- a/net/hsr/hsr_framereg.c +++ b/net/hsr/hsr_framereg.c @@ -415,7 +415,7 @@ void hsr_addr_subst_dest(struct hsr_node *node_src, struct sk_buff *skb, node_dst = find_node_by_addr_A(&port->hsr->node_db, eth_hdr(skb)->h_dest); if (!node_dst) { - if (net_ratelimit()) + if (net_ratelimit() && port->hsr->prot_version != PRP_V1) netdev_err(skb->dev, "%s: Unknown node\n", __func__); return; } -- 2.39.2