From: Mario Limonciello <mario.limonciello@amd.com>
To: "Jan Dąbroś" <jsd@semihalf.com>,
"Grzegorz Bernacki" <gjb@semihalf.com>,
"Mark Hasemeyer" <markhas@chromium.org>,
"Mario Limonciello" <mario.limonciello@amd.com>,
"Tom Lendacky" <thomas.lendacky@amd.com>,
"John Allen" <john.allen@amd.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
<linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v6 1/4] crypto: ccp: Bump up doorbell debug messages to error
Date: Wed, 22 Mar 2023 16:02:23 -0500 [thread overview]
Message-ID: <20230322210227.464-2-mario.limonciello@amd.com> (raw)
In-Reply-To: <20230322210227.464-1-mario.limonciello@amd.com>
This is helpful not just for debugging problems, but also for investigating
captured logs later on.
Suggested-by: Grzegorz Bernacki <gjb@semihalf.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
drivers/crypto/ccp/platform-access.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/crypto/ccp/platform-access.c b/drivers/crypto/ccp/platform-access.c
index b51fb1196932..3e97ce60270d 100644
--- a/drivers/crypto/ccp/platform-access.c
+++ b/drivers/crypto/ccp/platform-access.c
@@ -157,19 +157,19 @@ int psp_ring_platform_doorbell(int msg)
mutex_lock(&pa_dev->doorbell_mutex);
if (check_doorbell(button)) {
- dev_dbg(psp->dev, "doorbell is not ready\n");
+ dev_err(psp->dev, "doorbell is not ready\n");
ret = -EBUSY;
goto unlock;
}
if (check_recovery(cmd)) {
- dev_dbg(psp->dev, "doorbell command in recovery\n");
+ dev_err(psp->dev, "doorbell command in recovery\n");
ret = -EBUSY;
goto unlock;
}
if (wait_cmd(cmd)) {
- dev_dbg(psp->dev, "doorbell command not done processing\n");
+ dev_err(psp->dev, "doorbell command not done processing\n");
ret = -EBUSY;
goto unlock;
}
--
2.34.1
next prev parent reply other threads:[~2023-03-22 21:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 21:02 [PATCH v6 0/4] Use CCP driver to handle PSP I2C arbitration Mario Limonciello
2023-03-22 21:02 ` Mario Limonciello [this message]
2023-03-22 21:02 ` [PATCH v6 2/4] crypto: ccp: Return doorbell status code as an argument Mario Limonciello
2023-03-27 16:26 ` Mark Hasemeyer
2023-03-22 21:02 ` [PATCH v6 3/4] i2c: designware: Use PCI PSP driver for communication Mario Limonciello
2023-03-23 13:08 ` Andy Shevchenko
2023-03-23 18:34 ` kernel test robot
2023-03-24 2:35 ` kernel test robot
2023-03-22 21:02 ` [PATCH v6 4/4] i2c: designware: Add doorbell support for Mendocino Mario Limonciello
2023-03-23 13:06 ` Andy Shevchenko
2023-03-23 13:32 ` Limonciello, Mario
2023-03-24 20:40 ` kernel test robot
2023-03-27 16:37 ` Mark Hasemeyer
2023-03-27 17:05 ` Limonciello, Mario
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230322210227.464-2-mario.limonciello@amd.com \
--to=mario.limonciello@amd.com \
--cc=davem@davemloft.net \
--cc=gjb@semihalf.com \
--cc=herbert@gondor.apana.org.au \
--cc=john.allen@amd.com \
--cc=jsd@semihalf.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markhas@chromium.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®