From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D525C7619A for ; Fri, 24 Mar 2023 01:52:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230486AbjCXBwX (ORCPT ); Thu, 23 Mar 2023 21:52:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229499AbjCXBwU (ORCPT ); Thu, 23 Mar 2023 21:52:20 -0400 Received: from smtpbgjp3.qq.com (smtpbgjp3.qq.com [54.92.39.34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE92A2331A; Thu, 23 Mar 2023 18:52:18 -0700 (PDT) X-QQ-mid: bizesmtp81t1679622724t44d0krm Received: from localhost.localdomain ( [113.200.76.118]) by bizesmtp.qq.com (ESMTP) with id ; Fri, 24 Mar 2023 09:52:03 +0800 (CST) X-QQ-SSF: 01400000000000B0E000000A0000000 X-QQ-FEAT: fQ7bGlHvZRF4Sn2zEN6FX0NS95S4FTJ9NyzD7uSP8SFE1RnwJWLrQVbaOLqT1 Atqlhfwx3tYgh6kDX+r7nd4Rwq9f0k4J4gbp1c99PHn4X5LUDUBLRL36gdUjjw0gmDgw7CW vmQT9IDtivSuYgQWpQEJeVp92trHQ9YZwlS0dSjvONcEiwcyq9gc8WJDKuLE6ZQdZDDM2v6 v4MBf9KLWu3LfRgWtC4teGF1R3tsVl2A3wsIw5zLUOVXVVzdhBaEMLf/Kf7h3KhP/T/u/rD YSfmH5XZtTqkHK0l5m8ujDa8xmaRUcyK53vMUEIBuu3Q+/1DFG8VHEeHTXOpYvDmDF4hcps lPLz6PVZDBfuP3Yd2EJj3vgrMzR0yG5D7Te+a4yyg73yIxHg2sCriMUhCEZn7dxW0gVh7a4 X-QQ-GoodBg: 1 From: gouhao@uniontech.com To: willy@infradead.org Cc: brauner@kernel.org, gouhao@uniontech.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk Subject: Re: [PATCH] fs/buffer: adjust the order of might_sleep() in __getblk_gfp() Date: Fri, 24 Mar 2023 09:52:01 +0800 Message-Id: <20230324015201.12511-1-gouhao@uniontech.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:uniontech.com:qybglogicsvr:qybglogicsvr7 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >On Thu, Mar 23, 2023 at 05:37:52PM +0800, gouhao@uniontech.com wrote: >> From: Gou Hao >> >> If 'bh' is found in cache, just return directly. >> might_sleep() is only required on slow paths. > >You're missing the point. The caller can't know whether the slow or >fast path will be taken. So it must _never_ call this function if it >cannot sleep. I see. Thank you for your explanation! :)