From: Joseph Strauss <jstrauss@mailbox.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: lee@kernel.org, jansimon.moeller@gmx.de, conor@kernel.org,
christophe.jaillet@wanadoo.fr, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Add multicolor support to BlinkM LED driver
Date: Sat, 25 Mar 2023 10:53:55 -0500 [thread overview]
Message-ID: <20230325155355.gxnjpyl3mnyq2lst@libretux> (raw)
In-Reply-To: <ZBw5E4ecNvfgd0RB@duo.ucw.cz>
On 23/03/23 12:33PM, Pavel Machek wrote:
> Hi!
>
> > In the blinkm_probe function, the multicolor LED class is registered
> > after the regular LED classes. The blinkm_set_mc_brightness() function
> > had to be added to calculate the three color components and then set the
> > fields of the blinkm_data structure accordingly.
>
> It needs to be either single multicolor LED or three separate
> LEDs. But not both at the same time.
>
Thank you for the feedback! How would you suggest I go about handling
this? Is there a preferred way to ask the user which way they want to
control the LED (Kconfig?), or should I remove the code for three
separate LEDs entirely? Originally, I didn't delete the code because I
thought it would be bad to remove the existing interface.
Joe Strauss
next prev parent reply other threads:[~2023-03-25 16:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-28 1:09 Joseph Strauss
2023-01-09 16:56 ` Lee Jones
2023-03-01 14:26 ` Lee Jones
2023-03-15 16:16 ` Lee Jones
2023-03-22 23:21 ` Joseph Strauss
2023-03-23 12:28 ` Lee Jones
2023-03-23 11:33 ` Pavel Machek
2023-03-25 15:53 ` Joseph Strauss [this message]
2023-03-25 16:09 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230325155355.gxnjpyl3mnyq2lst@libretux \
--to=jstrauss@mailbox.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=conor@kernel.org \
--cc=jansimon.moeller@gmx.de \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®