From: Caio Novais <caionovais@usp.br>
To: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Harry Wentland" <harry.wentland@amd.com>,
"Leo Li" <sunpeng.li@amd.com>,
"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
"Jack Xiao" <Jack.Xiao@amd.com>,
"Hawking Zhang" <Hawking.Zhang@amd.com>, "Le Ma" <le.ma@amd.com>,
"Mario Limonciello" <mario.limonciello@amd.com>,
"Yifan Zhang" <yifan1.zhang@amd.com>,
"Mukul Joshi" <mukul.joshi@amd.com>, "Jun Lei" <Jun.Lei@amd.com>,
"Wenjing Liu" <wenjing.liu@amd.com>,
"Alan Liu" <HaoPing.Liu@amd.com>,
"Caio Novais" <caionovais@usp.br>,
"Joshua Ashton" <joshua@froggi.es>,
"Guo Zhengkui" <guozhengkui@vivo.com>,
"Nicholas Kazlauskas" <Nicholas.Kazlauskas@amd.com>,
"Zhan Liu" <zhan.liu@amd.com>, "Wayne Lin" <wayne.lin@amd.com>,
"Charlene Liu" <Charlene.Liu@amd.com>,
"Martin Leung" <Martin.Leung@amd.com>,
"Tom Chung" <chiahsuan.chung@amd.com>,
"Alvin Lee" <alvin.lee2@amd.com>,
"George Shen" <George.Shen@amd.com>,
"Qingqing Zhuo" <qingqing.zhuo@amd.com>,
"Roman Li" <Roman.Li@amd.com>,
"Wesley Chalmers" <Wesley.Chalmers@amd.com>,
"Aurabindo Pillai" <aurabindo.pillai@amd.com>,
"Jingwen Zhu" <Jingwen.Zhu@amd.com>,
"Melissa Wen" <mwen@igalia.com>,
"Felipe Clark" <felipe.clark@amd.com>,
"Sung Joon Kim" <sungjoon.kim@amd.com>,
"Dillon Varone" <Dillon.Varone@amd.com>,
"Ethan Wellenreiter" <Ethan.Wellenreiter@amd.com>,
"Taimur Hassan" <Syed.Hassan@amd.com>,
"Maíra Canal" <mairacanal@riseup.net>,
"Brian Chang" <Brian.Chang@amd.com>,
"Gabe Teeger" <gabe.teeger@amd.com>,
"André Almeida" <andrealmeid@igalia.com>,
"Chaitanya Dhere" <chaitanya.dhere@amd.com>,
"Jiapeng Chong" <jiapeng.chong@linux.alibaba.com>,
"Ryan Lin" <tsung-hua.lin@amd.com>,
"Hamza Mahfooz" <hamza.mahfooz@amd.com>
Subject: [PATCH 09/12] drm/amd/display: Remove two unused variables 'is_pipe_split_expected' and 'state'
Date: Mon, 27 Mar 2023 20:33:50 -0300 [thread overview]
Message-ID: <20230327233353.64081-10-caionovais@usp.br> (raw)
In-Reply-To: <20230327233353.64081-1-caionovais@usp.br>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 2139 bytes --]
Compiling AMD GPU drivers displays two warnings:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource.c: In function ‘dcn32_acquire_post_bldn_3dlut’:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource.c:1614:31: warning: variable ‘state’ set but not used [-Wunused-but-set-variable]
and
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource.c: In function ‘dcn32_populate_dml_pipes_from_context’:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource.c:1916:17: warning: variable ‘is_pipe_split_expected’ set but not used [-Wunused-but-set-variable]
Get rid of them by removing the variables.
Signed-off-by: Caio Novais <caionovais@usp.br>
---
drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource.c
index 74e50c09bb62..3435d3294e0b 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource.c
@@ -1611,7 +1611,6 @@ bool dcn32_acquire_post_bldn_3dlut(
struct dc_transfer_func **shaper)
{
bool ret = false;
- union dc_3dlut_state *state;
ASSERT(*lut == NULL && *shaper == NULL);
*lut = NULL;
@@ -1620,7 +1619,6 @@ bool dcn32_acquire_post_bldn_3dlut(
if (!res_ctx->is_mpc_3dlut_acquired[mpcc_id]) {
*lut = pool->mpc_lut[mpcc_id];
*shaper = pool->mpc_shaper[mpcc_id];
- state = &pool->mpc_lut[mpcc_id]->state;
res_ctx->is_mpc_3dlut_acquired[mpcc_id] = true;
ret = true;
}
@@ -1913,7 +1911,6 @@ int dcn32_populate_dml_pipes_from_context(
struct resource_context *res_ctx = &context->res_ctx;
struct pipe_ctx *pipe;
bool subvp_in_use = false;
- uint8_t is_pipe_split_expected[MAX_PIPES] = {0};
struct dc_crtc_timing *timing;
dcn20_populate_dml_pipes_from_context(dc, context, pipes, fast_validate);
@@ -2002,7 +1999,6 @@ int dcn32_populate_dml_pipes_from_context(
}
DC_FP_START();
- is_pipe_split_expected[i] = dcn32_predict_pipe_split(context, &pipes[pipe_cnt]);
DC_FP_END();
pipe_cnt++;
--
2.40.0
next prev parent reply other threads:[~2023-03-27 23:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 23:33 [PATCH 00/12] drm/amd: Remove unused variables Caio Novais
2023-03-27 23:33 ` [PATCH 01/12] drm/amd: Remove unused variable 'r' Caio Novais
2023-03-27 23:46 ` Alex Deucher
2023-03-27 23:33 ` [PATCH 02/12] drm/amd: Remove unused variable 'value0' Caio Novais
2023-03-27 23:48 ` Alex Deucher
2023-03-27 23:33 ` [PATCH 03/12] drm/amd/display: Remove unused variable 'pixel_width' Caio Novais
2023-03-27 23:33 ` [PATCH 04/12] drm/amd/display: Remove unused variable 'hubp' Caio Novais
2023-03-27 23:33 ` [PATCH 05/12] drm/amd/display: Remove unused variable 'speakers' Caio Novais
2023-03-27 23:33 ` [PATCH 06/12] drm/amd/display: Remove unused variable 'mc_vm_apt_default' Caio Novais
2023-03-27 23:33 ` [PATCH 07/12] drm/amd/display: Remove unused variable 'optc' Caio Novais
2023-03-27 23:33 ` [PATCH 08/12] drm/amd/display: Remove two unused variables 'speakers' and 'channels' and remove unused function 'speakers_to_channels' Caio Novais
2023-03-27 23:33 ` Caio Novais [this message]
2023-03-27 23:50 ` [PATCH 09/12] drm/amd/display: Remove two unused variables 'is_pipe_split_expected' and 'state' Alex Deucher
2023-03-27 23:33 ` [PATCH 10/12] drm/amd/display: Remove unused variable 'cursor_bpp' Caio Novais
2023-03-27 23:33 ` [PATCH 11/12] drm/amd/display: Remove unused variable 'scl_enable' Caio Novais
2023-03-27 23:33 ` [PATCH 12/12] drm/amd/display: Remove two unused variables 'result_write_min_hblank' and 'hblank_size' Caio Novais
2023-03-27 23:53 ` Alex Deucher
2023-03-28 10:16 ` [PATCH 00/12] drm/amd: Remove unused variables Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230327233353.64081-10-caionovais@usp.br \
--to=caionovais@usp.br \
--cc=Brian.Chang@amd.com \
--cc=Charlene.Liu@amd.com \
--cc=Dillon.Varone@amd.com \
--cc=Ethan.Wellenreiter@amd.com \
--cc=George.Shen@amd.com \
--cc=HaoPing.Liu@amd.com \
--cc=Hawking.Zhang@amd.com \
--cc=Jack.Xiao@amd.com \
--cc=Jingwen.Zhu@amd.com \
--cc=Jun.Lei@amd.com \
--cc=Martin.Leung@amd.com \
--cc=Nicholas.Kazlauskas@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Roman.Li@amd.com \
--cc=Syed.Hassan@amd.com \
--cc=Wesley.Chalmers@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=alvin.lee2@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrealmeid@igalia.com \
--cc=aurabindo.pillai@amd.com \
--cc=chaitanya.dhere@amd.com \
--cc=chiahsuan.chung@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=felipe.clark@amd.com \
--cc=gabe.teeger@amd.com \
--cc=guozhengkui@vivo.com \
--cc=hamza.mahfooz@amd.com \
--cc=harry.wentland@amd.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=joshua@froggi.es \
--cc=le.ma@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mairacanal@riseup.net \
--cc=mario.limonciello@amd.com \
--cc=mukul.joshi@amd.com \
--cc=mwen@igalia.com \
--cc=qingqing.zhuo@amd.com \
--cc=sungjoon.kim@amd.com \
--cc=sunpeng.li@amd.com \
--cc=tsung-hua.lin@amd.com \
--cc=wayne.lin@amd.com \
--cc=wenjing.liu@amd.com \
--cc=yifan1.zhang@amd.com \
--cc=zhan.liu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®