From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC389C76196 for ; Tue, 28 Mar 2023 13:01:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232170AbjC1NBF (ORCPT ); Tue, 28 Mar 2023 09:01:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231871AbjC1NBD (ORCPT ); Tue, 28 Mar 2023 09:01:03 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD3A58A42 for ; Tue, 28 Mar 2023 06:00:56 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ph8wT-0007D9-3D; Tue, 28 Mar 2023 15:00:49 +0200 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1ph8wQ-0000Dv-T4; Tue, 28 Mar 2023 15:00:46 +0200 Date: Tue, 28 Mar 2023 15:00:46 +0200 From: Oleksij Rempel To: Andrew Lunn Cc: Wei Fang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Heiner Kallweit , Russell King , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Shenwei Wang , Clark Wang , NXP Linux Team , Amit Cohen , Gal Pressman , Alexandru Tachici , Piergiorgio Beruto , Willem de Bruijn , Vladimir Oltean Subject: Re: [PATCH net-next v2 6/8] net: phy: at803x: Make SmartEEE support optional and configurable via ethtool Message-ID: <20230328130046.GG15196@pengutronix.de> References: <20230327142202.3754446-1-o.rempel@pengutronix.de> <20230327142202.3754446-7-o.rempel@pengutronix.de> <20230328120514.GF15196@pengutronix.de> <9557a753-7ba5-41aa-84e2-f449c92d7d16@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <9557a753-7ba5-41aa-84e2-f449c92d7d16@lunn.ch> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 28, 2023 at 02:49:58PM +0200, Andrew Lunn wrote: > > > @@ -302,6 +312,8 @@ struct at803x_priv { > > > u8 smarteee_lpi_tw_100m; > > > bool is_fiber; > > > bool is_1000basex; > > > + bool tx_lpi_on; > > > > @Andrew, this variable can be replace by your phydev->tx_lpi_enabled > > variable. Should I wait for your patches went mainline? > > I was wondering about the overlap and the best way to address it. > > My patchset is also a bit big, and getting bigger. So it might make > sense to split out some of the bits you need and get them merged > first. > > You need the MAC indicating it is EEE capable. I don't store that > information explicitly, but that is a quick simple change. You also > need phydev->tx_lpi_enabled. Anything else? No. It's fine. Thx! Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |