From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0278C761A6 for ; Thu, 30 Mar 2023 16:53:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231851AbjC3QxW (ORCPT ); Thu, 30 Mar 2023 12:53:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231459AbjC3QxF (ORCPT ); Thu, 30 Mar 2023 12:53:05 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 230FCEB54 for ; Thu, 30 Mar 2023 09:52:51 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id y144-20020a253296000000b00b69ce0e6f2dso19368386yby.18 for ; Thu, 30 Mar 2023 09:52:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1680195170; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=mQYDmK2JgUqCpCRVA2d0KYhO6AxXou2BaS+5pOIMpjU=; b=Qhwvho/jSCzD962UhSp8uw5ox5R2LCORWuT38KhF1g8kOlUAdKNLzt4oWIseQg7qy5 w7ssDt5UoFmaEOfi2vxsVKdWffZwOyk9SvIH1DtxV7SaetvZLdGPBi9lKWgf7qUPSVtH ASeXYWr/h3EdvlTVN8GZhAr+KU6of6ZeHB90/1jZ1BKAUXAHr1F1ZCDoZ935l51aeNBu N0E1aGMWwpTJOL0st3TggxhzN+bz+EYaXjh7GBoidWRNNGBfmlCvx4E8vijMA/M8+sdk 7fB1TBG+FcXSIh1nNwyzmJq53L1X/KhAKwwh8/ctLfsGGCD1QCGM2Iki1y+qZLDOPx3p E0Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680195170; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mQYDmK2JgUqCpCRVA2d0KYhO6AxXou2BaS+5pOIMpjU=; b=Er0pI0Eh4xZeI4pSqerVh2kWUBqXkzCBTTjBZDW9rWwT/zQLn77R8QFlrUVv0zJZbT CS2ufPNNzyCW84kUzY+3f14AaySMtb5u+KrZNPvCzu6H8SBdldPRx71831tF0Xwp/frI b6wU+/i2DzzO20pJPt2haj8C0tWWka57atBchK/hBvO2Kc9yaGZkg18LMV7RFoB3a3lZ zqzvvRqpvVN63DGNuwX9C5YcIguqhCvm5KRrqnMaf1M9d2OrNBJqgXyVnMQZbg9VkEVJ g9Uf/vK62n+FSJzZX8Ef6MxasCsQ3s0rPNtfEGyV7fM0ACd/bIJJBflGTEMuDdnjQ4pC Rr2w== X-Gm-Message-State: AAQBX9fdOmuSsjXXKgAOV17JXlMUrRcsyOAIE2r86ngHEEFn86YhV4lt k8+Xckvu6qTlyWVnDlElv8nBMm8QLcVrkg== X-Google-Smtp-Source: AKy350ZKQUPsiA6P7BhOGzirXB+KdSmGZo7ozykgr9T5Dtqy7WkMW7GodFAWWOkH7jqts/4Tipe33E5WWOFTow== X-Received: from shakeelb.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:262e]) (user=shakeelb job=sendgmr) by 2002:a05:6902:1004:b0:b75:968e:f282 with SMTP id w4-20020a056902100400b00b75968ef282mr15755101ybt.11.1680195170260; Thu, 30 Mar 2023 09:52:50 -0700 (PDT) Date: Thu, 30 Mar 2023 16:52:48 +0000 In-Reply-To: <20230330133822.66271-1-mathieu.desnoyers@efficios.com> Mime-Version: 1.0 References: <20230330133822.66271-1-mathieu.desnoyers@efficios.com> Message-ID: <20230330165248.rv7bssd6ys6m33od@google.com> Subject: Re: [PATCH 1/1] mm: Fix memory leak on mm_init error handling From: Shakeel Butt To: Mathieu Desnoyers Cc: Andrew Morton , linux-kernel@vger.kernel.org, Marek Szyprowski , linux-mm@kvack.org, stable@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 30, 2023 at 09:38:22AM -0400, Mathieu Desnoyers wrote: > commit f1a7941243c1 ("mm: convert mm's rss stats into percpu_counter") > introduces a memory leak by missing a call to destroy_context() when a > percpu_counter fails to allocate. > > Before introducing the per-cpu counter allocations, init_new_context() > was the last call that could fail in mm_init(), and thus there was no > need to ever invoke destroy_context() in the error paths. Adding the > following percpu counter allocations adds error paths after > init_new_context(), which means its associated destroy_context() needs > to be called when percpu counters fail to allocate. > Fixes: f1a7941243c1 ("mm: convert mm's rss stats into percpu_counter") > Signed-off-by: Mathieu Desnoyers > Cc: Shakeel Butt > Cc: Andrew Morton > Cc: Marek Szyprowski > Cc: linux-mm@kvack.org > Cc: stable@vger.kernel.org # 6.2 Acked-by: Shakeel Butt